feat(feedback): add BE prompt for hiding feedback from issue details #74219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
| @@ -19,6 +19,7 @@ | |||
| "data_consent_banner": {"required_fields": ["organization_id"]}, | |||
| "data_consent_priority": {"required_fields": ["organization_id"]}, | |||
| "issue_replay_inline_onboarding": {"required_fields": ["organization_id", "project_id"]}, | |||
| "issue_feedback_hidden": {"required_fields": ["organization_id", "project_id"]}, | |||
There was a problem hiding this comment.
what if we renamed it to something like issue_user_feedback? the trend seems to be that the names should be more related to the component rather than the action
There was a problem hiding this comment.
I think the _hidden makes it more clear what the component is using this prompt for
There was a problem hiding this comment.
i think all prompts are used for hiding/dismissing something tho, it's implied but im not super adamant on it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74219 +/- ##
===========================================
+ Coverage 57.27% 78.13% +20.85%
===========================================
Files 6445 6665 +220
Lines 285309 297901 +12592
Branches 49067 51274 +2207
===========================================
+ Hits 163400 232751 +69351
+ Misses 117384 58875 -58509
- Partials 4525 6275 +1750
|
michellewzhang
approved these changes
Jul 12, 2024
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #74209