fix(integrations)-org-in-url-notify-disable #54234
Conversation
github-actions
bot
added
the
Scope: Backend
| integration.slug if hasattr(integration, "slug") else integration.provider, | ||
| ) | ||
|
|
||
| integration_name = ( |
There was a problem hiding this comment.
@chloeho7 can we expose methods on the SentryApp and RpcIntegration to return the slug/name so this function doesn't have to have this kind of logic?
There was a problem hiding this comment.
Sure, now using .get_provider() from RpcIntegration instead of hasattr()
There was a problem hiding this comment.
Damn typing really doesn't like this, it'll have to be rewritten a bit.
| f"/settings/{self.organization.slug}/integrations/{self.integration.provider}" | ||
| ) | ||
| in msg.body | ||
| ) |
There was a problem hiding this comment.
Could you add a test to make sure the URL is correct for sentry apps? You can add it in #53522 after this is merged and you rebase
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54234 +/- ##
==========================================
+ Coverage 79.63% 79.64% +0.01%
==========================================
Files 4982 4985 +3
Lines 211115 211381 +266
Branches 35964 36026 +62
==========================================
+ Hits 168111 168357 +246
- Misses 37837 37848 +11
- Partials 5167 5176 +9
|
Fix for #53533
Replace URL for notify when integrations are disabled with:
/settings/sentry/developer-settings/just-a-test-eb81a3/Currently:
/settings/developer-settings/projects/just%20a%20test/Part of Notify on Disabled Integration project