feat(integration): Notify on Disable Email #53533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceorourke
reviewed
Jul 28, 2023
ceorourke
reviewed
Jul 28, 2023
ceorourke
reviewed
Jul 28, 2023
ceorourke
reviewed
Jul 28, 2023
ceorourke
reviewed
Jul 31, 2023
| if not provider_type: | ||
| return str(organization.absolute_url("/settings/integrations/")) | ||
|
|
||
| type_name = provider_types.get(provider_type, "") |
There was a problem hiding this comment.
Just to be super safe since the fallback is an empty string here, what if we shuffled the logic around like this:
def get_url(organization: Organization, provider_type: str, provider: str) -> str:
if provider_type:
type_name = provider_types.get(provider_type, "")
if type_name:
return str(
organization.absolute_url(
f"/settings/{type_name}/{provider}/",
)
)
return str(organization.absolute_url("/settings/integrations/"))
This way we account for the possibility of there not being a provider_type and type_name.
ceorourke
approved these changes
Jul 31, 2023
chloeho7
added a commit
that referenced
this pull request
Aug 7, 2023
Fix for #53533 Replace URL for notify when integrations are disabled with: `/settings/sentry/developer-settings/just-a-test-eb81a3/` Currently: `/settings/developer-settings/projects/just%20a%20test/` Part of [Notify on Disabled Integration project](https://www.notion.so/sentry/Tech-Spec-Notify-on-Disabled-Integration-Spec-e7ea0f86ccd6419cb3e564067cf4a2ef?pvs=4)
This was referenced Aug 8, 2023
chloeho7
added a commit
that referenced
this pull request
Aug 9, 2023
Analytics for #53621 and #53533 Closes #53568 Adding to amplitude here: https://github.com/getsentry/etl/pull/1167
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #53567
Milestone 1 of Notify on Disabled Integration project
Implementing email notification when detected broken integrations and disabled.
Disabling and notifying implemented under feature flag "slack-disable-on-broken".