-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(slack): notify on disable analytics #54421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/sentry/integrations/analytics.py
Outdated
|
||
attributes = ( | ||
analytics.Attribute("organization_id"), | ||
analytics.Attribute("redis_key"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the redis key? If we have the provider and org ID that should be enough for us to tell which integration is disabled and for whom.
type = "integration.disabled.notified" | ||
|
||
attributes = ( | ||
analytics.Attribute("organization_id"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chloeho7 can we add a user id so we can send it to Amplitude? It can be the default owner id.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54421 +/- ##
=======================================
Coverage 79.65% 79.66%
=======================================
Files 4989 4989
Lines 211491 211571 +80
Branches 36048 36061 +13
=======================================
+ Hits 168471 168542 +71
- Misses 37834 37840 +6
- Partials 5186 5189 +3
|
|
||
attributes = ( | ||
analytics.Attribute("organization_id"), | ||
analytics.Attribute("provider"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chloeho7 I think we should still have some sort of integration/installation id field and then a type. That way we can do a join on the right table based on the type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the type and parsed integration/installation id from the redis key
src/sentry/integrations/analytics.py
Outdated
attributes = ( | ||
analytics.Attribute("organization_id"), | ||
analytics.Attribute("provider"), | ||
analytics.Attribute("user_id"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chloeho7 let's make this optional because some weird orgs don't have an owner
Analytics for #53621 and #53533
Closes #53568
Adding to amplitude here: https://github.com/getsentry/etl/pull/1167