fix(severity): Prevent skipping severity score when equal to zero #56225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential bug in assigning severity scores to new groups wherein the score wouldn't be assigned if it was equal to
0
. (Falsiness strikes again!) Since scores are currently handled as strings, this is only a hypothetical for now, but worth fixing in case we do ever treat score as a float instead.It also adds tests for this case and applies a fix I noticed while writing said tests to an existing test. (It now checks for the
severity
key actually being missing from group metadata rather thanseverity
being set toNone
.)