feat(statistical-detectors): Integrate detector with breakpoint detection #56384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Using the filtered list of project + functions, we now want to apply breakpoint detection to validate the regression. If there is a recent regression in the timeseries, these are what's seen as a regressed function.
github-actions
bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #56384 +/- ##
========================================
Coverage 78.64% 78.64%
========================================
Files 5075 5078 +3
Lines 218067 218396 +329
Branches 36905 36970 +65
========================================
+ Hits 171490 171751 +261
- Misses 41044 41100 +56
- Partials 5533 5545 +12
|
…integrate-detector-with-breakpoint-detection
udameli
reviewed
Sep 19, 2023
| "statistical_detectors.breakpoint.functions", | ||
| amount=breakpoint_count, | ||
| sample_rate=1.0, | ||
| ) |
There was a problem hiding this comment.
do you think it also makes sense to record a percentage of timeseries that actually had breakpoints
There was a problem hiding this comment.
I think we can derive the percentage by dividing this metric with the existing metrics so just having this count will suffice.
udameli
approved these changes
Sep 19, 2023
Zylphrex
deleted the
txiao/feat/integrate-detector-with-breakpoint-detection
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the filtered list of project + functions, we now want to apply breakpoint detection to validate the regression. If there is a recent regression in the timeseries, these are what's seen as a regressed function.