feat(ui): Add story-ui command to run internal storybook
#56511
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
seems unrelated to the build stuff but w/e
There was a problem hiding this comment.
It is related, it's no longer at /stories/ now
ryan953
requested changes
Sep 20, 2023
There was a problem hiding this comment.
Whatever the strategy is, we should make it work for getsentry too. I'm worried that splitting this off onto vercel has low value on it's own, and will prevent off all those components from participating which I think is more interesting.
We should describe the value of this PR instead of briefly restarting what the code states in the description.
evanpurkhiser
deleted the
evanpurkhiser/feat-ui-add-story-ui-command-to-run-internal-storybook
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
yarn story-uicommand that builds ONLY the internal sentry storybook stories.