docs: Create some stories for PageBanner #56519
Conversation
github-actions
bot
added
the
Scope: Frontend
| import {Fragment, useState} from 'react'; | ||
| import styled from '@emotion/styled'; | ||
|
|
||
| import replaysDeadRageBackground from 'sentry-images/spot/replay-dead-rage-changelog.svg'; |
There was a problem hiding this comment.
How does this affect bundling (if at all)?
There was a problem hiding this comment.
I don't know specifically, didn't look at webpack output. But I don't think it's something we should worry about, webpack as an abstraction should be doing the right thing. Over time as more stories appear there will be lots of story files (async loaded btw) which will import random things.
In the case of import Button, it's used in basically every file, and webpack should be noticing that and splitting it out. With this I would think that webpack will notice the image is used with PageBanner and Button and t() and a few things, and then put it into a nice spot.
Related: There is a PR to split the /stories route into it's own build: #56511. There's some inartistic "oh the bundles" justification there, but I'm a bit worried we're cargo-culting something here.
We've got stories with with content, dismissable & resizable banners, and a story to explain adding color to the text.
I updated the styles inside the banner itself, so that inline content, like the "See Stories" link render inline:
