feat(alert rules): Create jira server alert rule action #58019

schew2381 · 2023-10-12T21:08:58Z

Summary

Create a new alert rule action for Jira Server that mirrors the existing Jira alert rule action.

Sending Test Notification

In the video below, I test creating all task types (epic, story, task, sub-task, bug) in Jira Server using the test notification

There is a visual bug here where the sending test notifications button disappears after a while, even though it's still going on. After all the actions have been run, Notifications sent! pops up but there's a big gap in between where nothing shows on screen to indicate things are still running.

Screen.Recording.2023-10-18.at.1.50.49.PM.mov

New Action on Create Alert Rule

codecov · 2023-10-12T23:20:20Z

Codecov Report

Merging #58019 (6a7f081) into master (05f116b) will increase coverage by 0.34%.
Report is 1 commits behind head on master.
The diff coverage is 92.15%.

@@            Coverage Diff             @@
##           master   #58019      +/-   ##
==========================================
+ Coverage   78.74%   79.08%   +0.34%     
==========================================
  Files        5140     5143       +3     
  Lines      223843   223891      +48     
  Branches    37696    37699       +3     
==========================================
+ Hits       176254   177068     +814     
+ Misses      41821    41154     -667     
+ Partials     5768     5669      -99

Files	Coverage Δ
src/sentry/api/endpoints/project_rule_details.py	`85.82% <100.00%> (+0.21%)`	⬆️
src/sentry/api/endpoints/project_rules.py	`95.45% <ø> (ø)`
src/sentry/integrations/jira_server/__init__.py	`100.00% <100.00%> (ø)`
...entry/integrations/jira_server/actions/__init__.py	`100.00% <100.00%> (ø)`
src/sentry/integrations/jira_server/integration.py	`69.90% <ø> (ø)`
.../sentry/integrations/vsts/actions/create_ticket.py	`100.00% <ø> (ø)`
...y/rules/actions/integrations/create_ticket/base.py	`94.44% <100.00%> (+0.21%)`	⬆️
src/sentry/rules/base.py	`90.19% <100.00%> (ø)`
.../integrations/jira_server/actions/create_ticket.py	`90.90% <90.90%> (ø)`
...rc/sentry/integrations/jira_server/actions/form.py	`86.66% <86.66%> (ø)`

... and 102 files with indirect coverage changes

schew2381 · 2023-10-16T17:55:05Z

tests/sentry/api/endpoints/test_project_rule_details.py

@@ -357,6 +361,65 @@ def test_with_jira_action_error(self):
            ["EPIC-2", "The Comeback Kid"],
        ]

+    @responses.activate
+    def test_with_jira_server_action_error(self):


copied from above jira integration test

schew2381 · 2023-10-16T17:55:35Z

tests/sentry/integrations/test_ticket_rules.py

@@ -149,3 +150,140 @@ def test_fails_validation(self):
                },
            )
            assert response.status_code == 400
+
+
+class JiraServerTicketRulesTestCase(RuleTestCase, BaseAPITestCase):


These tests were copied from JiraTicketRulesTestCase above

ceorourke

Did you test this locally with our Jira Server instance?

src/sentry/integrations/jira_server/actions/create_ticket.py

tests/sentry/integrations/test_ticket_rules.py

ceorourke · 2023-10-16T20:35:05Z

You'll also want to add this to the feature description list - see how it's defined in Jira cloud - https://github.com/getsentry/sentry/blob/master/src/sentry/integrations/jira/integration.py#L73-L78

ceorourke · 2023-10-16T20:38:02Z

I'd also blocked the sprint field ever being set for this in Jira cloud (see the PR) since it quickly results in failure once the sprint ends.

schew2381 · 2023-10-16T23:26:48Z

I'd also blocked the sprint field ever being set for this in Jira cloud (see the PR) since it quickly results in failure once the sprint ends.

I think this was already done for Jira Server if you check here: https://github.com/getsentry/sentry/blob/master/src/sentry/integrations/jira_server/integration.py#L823-L825

schew2381 · 2023-10-17T00:04:19Z

tests/sentry/integrations/test_ticket_rules.py

-        with mock.patch(
-            "sentry.integrations.jira.integration.JiraIntegration.get_client", self.get_client


This test is exactly the same except I removed this patch because the endpoint correctly fails before the mock is called

schew2381 · 2023-10-17T22:38:12Z

src/sentry/integrations/jira_server/integration.py

@@ -78,6 +78,12 @@
        """,
        IntegrationFeatures.ISSUE_SYNC,
    ),
+    FeatureDescription(
+        """
+        Automatically create Jira tickets based on Issue Alert conditions.


We don't say Jira Server for the other features, so I'm keeping parity by just using this Jira tickets

ceorourke

looks good! very thorough run through in the video

schew2381 self-assigned this Oct 12, 2023

schew2381 changed the title ~~feat(alerts): Create Jira Server Alert Rule Action~~ feat(alert-rules): Create Jira Server Alert Rule Action Oct 12, 2023

github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 12, 2023

schew2381 changed the title ~~feat(alert-rules): Create Jira Server Alert Rule Action~~ feat(alert-rules): Create jira server alert rule action Oct 12, 2023

schew2381 changed the title ~~feat(alert-rules): Create jira server alert rule action~~ feat(alert rules): Create jira server alert rule action Oct 12, 2023

vercel bot deployed to Preview October 12, 2023 21:11 View deployment

vercel bot deployed to Preview October 12, 2023 22:34 View deployment

vercel bot deployed to Preview October 12, 2023 22:41 View deployment

vercel bot deployed to Preview October 12, 2023 22:46 View deployment

vercel bot deployed to Preview October 12, 2023 23:56 View deployment

vercel bot deployed to Preview October 13, 2023 00:02 View deployment

vercel bot deployed to Preview October 13, 2023 17:13 View deployment

schew2381 and others added 8 commits October 13, 2023 10:17

create initial files and update everywhere we need ticket actions

fa290af

fix typing and ticket class id typo and tests

5175d43

fix more types and add more to test

07c724e

more tests and change issue to be called just jira w/o server

3315af5

remove unnecessary ignore

a8480d6

🔪 regenerate mypy module blocklist

730b0d7

reset typing

6583108

🔪 regenerate mypy module blocklist

8727fea

schew2381 force-pushed the seiji/feat/create-jira-server-ticket-action branch from 27e9a61 to 8727fea Compare October 13, 2023 17:17

vercel bot deployed to Preview October 13, 2023 17:21 View deployment

Merge branch 'master' into seiji/feat/create-jira-server-ticket-action

9b4da24

vercel bot deployed to Preview October 16, 2023 17:37 View deployment

schew2381 added 2 commits October 16, 2023 10:53

add back file

173f189

add back typing cuz already fixing some typing stuff

8fce5b7

schew2381 commented Oct 16, 2023

View reviewed changes

vercel bot deployed to Preview October 16, 2023 19:23 View deployment

split frontend into separate file

7b4f251

getsentry deleted a comment from github-actions bot Oct 16, 2023

schew2381 added Scope: Backend Automatically applied to PRs that change backend components and removed Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components labels Oct 16, 2023

vercel bot deployed to Preview October 16, 2023 19:34 View deployment

Merge branch 'master' into seiji/feat/create-jira-server-ticket-action

61dcb2b

vercel bot deployed to Preview October 16, 2023 20:28 View deployment

ceorourke reviewed Oct 16, 2023

View reviewed changes

switch from jira mock to mock responses

6a701f4

vercel bot deployed to Preview October 16, 2023 23:19 View deployment

schew2381 mentioned this pull request Oct 16, 2023

chore(jira): Remove jira server blurb about not having alert rule action getsentry/sentry-docs#8258

Merged

return straight domain_name instead of stripping

447f274

schew2381 commented Oct 17, 2023

View reviewed changes

vercel bot deployed to Preview October 17, 2023 00:07 View deployment

sentaur-athena approved these changes Oct 17, 2023

View reviewed changes

Merge branch 'master' into seiji/feat/create-jira-server-ticket-action

896d085

vercel bot deployed to Preview October 17, 2023 17:30 View deployment

schew2381 commented Oct 17, 2023

View reviewed changes

Merge branch 'master' into seiji/feat/create-jira-server-ticket-action

6a7f081

vercel bot deployed to Preview October 18, 2023 20:32 View deployment

schew2381 requested a review from ceorourke October 18, 2023 20:56

ceorourke approved these changes Oct 18, 2023

View reviewed changes

schew2381 merged commit b254c48 into master Oct 18, 2023

schew2381 deleted the seiji/feat/create-jira-server-ticket-action branch October 18, 2023 21:12

github-actions bot locked and limited conversation to collaborators Nov 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(alert rules): Create jira server alert rule action #58019

feat(alert rules): Create jira server alert rule action #58019

Uh oh!

schew2381 commented Oct 12, 2023 •

edited

Loading

Uh oh!

codecov bot commented Oct 12, 2023 •

edited

Loading

Uh oh!

schew2381 Oct 16, 2023

Uh oh!

schew2381 Oct 16, 2023

Uh oh!

ceorourke left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ceorourke commented Oct 16, 2023

Uh oh!

ceorourke commented Oct 16, 2023

Uh oh!

schew2381 commented Oct 16, 2023

Uh oh!

schew2381 Oct 17, 2023 •

edited

Loading

Uh oh!

schew2381 Oct 17, 2023 •

edited

Loading

Uh oh!

ceorourke left a comment

Uh oh!

Uh oh!

		with mock.patch(
		"sentry.integrations.jira.integration.JiraIntegration.get_client", self.get_client

Uh oh!

feat(alert rules): Create jira server alert rule action #58019

feat(alert rules): Create jira server alert rule action #58019

Uh oh!

Conversation

schew2381 commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Sending Test Notification

New Action on Create Alert Rule

Uh oh!

codecov bot commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

schew2381 Oct 16, 2023

Choose a reason for hiding this comment

Uh oh!

schew2381 Oct 16, 2023

Choose a reason for hiding this comment

Uh oh!

ceorourke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ceorourke commented Oct 16, 2023

Uh oh!

ceorourke commented Oct 16, 2023

Uh oh!

schew2381 commented Oct 16, 2023

Uh oh!

schew2381 Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

schew2381 Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ceorourke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

schew2381 commented Oct 12, 2023 •

edited

Loading

codecov bot commented Oct 12, 2023 •

edited

Loading

schew2381 Oct 17, 2023 •

edited

Loading

schew2381 Oct 17, 2023 •

edited

Loading