Skip to content

feat(api): Create query param to show disabled ticket integrations #58058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2023
Merged

feat(api): Create query param to show disabled ticket integrations #58058

merged 3 commits into from
Oct 16, 2023

Conversation

schew2381
Copy link
Contributor

@schew2381 schew2381 commented Oct 12, 2023 •
edited
Loading

We want to show disabled integrations on the alert rule action dropdown. Each disabled integration would have a button on the right linking to respective integration setup page.

This change allows us to pass a query parameter that will then include all disabled ticket actions in the response.

Mockup

Untitled

@schew2381 schew2381 requested a review from a team October 12, 2023 23:16
@schew2381 schew2381 self-assigned this Oct 12, 2023
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 12, 2023
schew2381
schew2381 commented Oct 12, 2023
View reviewed changes
src/sentry/api/endpoints/project_rules_configuration.py Outdated
@@ -81,4 +83,9 @@ def get(self, request: Request, project) -> Response:

context = {"actions": action_list, "conditions": condition_list, "filters": filter_list}

if request.GET.get("includeAllTickets") is not None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very open to alternative names for the query parameter includeAllTickets or the response key disabledTicketActions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need to take into account can_create_tickets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good catch, added that in

@schew2381 schew2381 marked this pull request as ready for review October 12, 2023 23:17
@schew2381 schew2381 requested a review from a team as a code owner October 12, 2023 23:17
@schew2381 schew2381 mentioned this pull request Oct 12, 2023
Merged
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #58058 (f1a8e42) into master (dfc5238) will decrease coverage by 0.01%.
Report is 34 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head f1a8e42 differs from pull request most recent head 0fc7fa4. Consider uploading reports for the commit 0fc7fa4 to get more accurate results

@@            Coverage Diff             @@
##           master   #58058      +/-   ##
==========================================
- Coverage   79.02%   79.02%   -0.01%     
==========================================
  Files        5130     5130              
  Lines      223040   223050      +10     
  Branches    37561    37563       +2     
==========================================
+ Hits       176264   176268       +4     
- Misses      41139    41142       +3     
- Partials     5637     5640       +3
Files Coverage Δ
...entry/api/endpoints/project_rules_configuration.py 96.36% <100.00%> (+0.36%) ⬆️

... and 7 files with indirect coverage changes

ceorourke
ceorourke approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems fine, will the disabled integrations in the list be greyed out / obvious that they're disabled? You might consider linking to the integration details page rather than the setup docs, since to re-enable you just need to re-install.

@schew2381
Copy link
Contributor Author

Change seems fine, will the disabled integrations in the list be greyed out / obvious that they're disabled? You might consider linking to the integration details page rather than the setup docs, since to re-enable you just need to re-install.

Ah yes that'd be better, I'll do that instead

@schew2381 schew2381 merged commit c23f143 into master Oct 16, 2023
@schew2381 schew2381 deleted the seiji/feat/add-query-param-to-show-disabled-integrations branch October 16, 2023 16:58
schew2381 added a commit that referenced this pull request Oct 18, 2023
@schew2381 @getsantry
feat(alert rules): Create jira server alert rule action (#58019)
b254c48 
Requires #58058
#58186

### Summary
Create a new alert rule action for Jira Server that mirrors the existing
Jira alert rule action.

----

### Sending Test Notification
In the video below, I test creating all task types (epic, story, task,
sub-task, bug) in Jira Server using the test notification

There is a visual bug here where the `sending test notifications` button
disappears after a while, even though it's still going on. After all the
actions have been run, `Notifications sent!` pops up but there's a big
gap in between where nothing shows on screen to indicate things are
still running.



https://github.com/getsentry/sentry/assets/67301797/d61ff9e4-312f-4529-8961-3e827df61b28

-----

### New Action on Create Alert Rule
<img width="538" alt="Screenshot 2023-10-16 at 12 15 53 PM"
src="https://github.com/getsentry/sentry/assets/67301797/be8a41c4-541c-4d38-985a-3dc73bf8438b">

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper left review comments

@ceorourke ceorourke ceorourke approved these changes

Assignees

@schew2381 schew2381

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schew2381 @scttcper @ceorourke