fix(performance-quick-trace-query): Using Sentry.captureException to inspect trace endpoint response. #58167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2023 11:52
…inspect trace endpoint response.
github-actions
bot
added
the
Scope: Frontend
k-fish
approved these changes
Oct 16, 2023
| @@ -73,6 +74,10 @@ export default function QuickTraceQuery({children, event, ...props}: QueryProps) | |||
| organization | |||
| ); | |||
|
|
|||
| const scope = new Sentry.Scope(); | |||
| const traceErrorMsg = 'Trace endpoints returning non-array in response'; | |||
There was a problem hiding this comment.
Will be getting rid of it all once I have some answers
| traceTransactions, | ||
| traceFullResults, | ||
| }); | ||
| Sentry.captureException(new Error(traceErrorMsg), scope); |
There was a problem hiding this comment.
If you're capturing this as an exception vs. a message it's fine (I usually just do message for exploratory work), but just watch the frontend errors once this is out, might trip an alert
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues: issue1 and issue2.
Prevents issue details page from failing. When error is triggered, we just display a link to the trace view without the navigator nodes.