Skip to content

fix(performance-quick-trace-query): Using Sentry.captureException to inspect trace endpoint response. #58167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 45 additions & 17 deletions static/app/utils/performance/quickTrace/quickTraceQuery.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {Fragment} from 'react';
import * as Sentry from '@sentry/react';

import {Event} from 'sentry/types/event';
import {DiscoverQueryProps} from 'sentry/utils/discover/genericDiscoverQuery';
Expand Down Expand Up @@ -73,6 +74,10 @@ export default function QuickTraceQuery({children, event, ...props}: QueryProps)
organization
);

const scope = new Sentry.Scope();
const traceErrorMsg = 'Trace endpoints returning non-array in response';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prob don't need a var here

Copy link
Contributor Author

@Abdkhan14 Abdkhan14 Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be getting rid of it all once I have some answers

scope.setFingerprint([traceErrorMsg]);

if (
!traceFullResults.isLoading &&
traceFullResults.error === null &&
Expand All @@ -88,19 +93,31 @@ export default function QuickTraceQuery({children, event, ...props}: QueryProps)
});
}

for (const subtrace of transactions ??
(traceFullResults.traces as TraceFull[])) {
try {
const trace = flattenRelevantPaths(event, subtrace);
return children({
...traceFullResults,
trace,
currentEvent: trace.find(e => isCurrentEvent(e, event)) ?? null,
});
} catch {
// let this fall through and check the next subtrace
// or use the trace lite results
const traceTransactions =
transactions ?? (traceFullResults.traces as TraceFull[]);

try {
for (const subtrace of traceTransactions) {
try {
const trace = flattenRelevantPaths(event, subtrace);
return children({
...traceFullResults,
trace,
currentEvent: trace.find(e => isCurrentEvent(e, event)) ?? null,
});
} catch {
// let this fall through and check the next subtrace
// or use the trace lite results
}
}
} catch {
// capture exception and let this fall through to
// use the /events-trace-lite/ response below
scope.setExtras({
traceTransactions,
traceFullResults,
});
Sentry.captureException(new Error(traceErrorMsg), scope);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're capturing this as an exception vs. a message it's fine (I usually just do message for exploratory work), but just watch the frontend errors once this is out, might trip an alert

}
}

Expand All @@ -118,14 +135,25 @@ export default function QuickTraceQuery({children, event, ...props}: QueryProps)
? orphanErrorsLite[0]
: undefined;
const traceTransactions = transactionLite ?? (trace as TraceLite);

let traceTransaction: EventLite | undefined;
try {
traceTransaction = traceTransactions.find(e => isCurrentEvent(e, event));
} catch {
scope.setExtras({
traceTransaction,
orphanError,
traceTransactions,
trace,
});
Sentry.captureException(new Error(traceErrorMsg), scope);
}

return children({
...traceLiteResults,
trace: traceTransactions,
trace: Array.isArray(traceTransactions) ? traceTransactions : [],
orphanErrors: orphanErrorsLite,
currentEvent:
orphanError ??
traceTransactions.find(e => isCurrentEvent(e, event)) ??
null,
currentEvent: orphanError ?? traceTransaction ?? null,
});
}

Expand Down