Skip to content

feat(alerts): Add migration warnings on detail and edit view #58431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2023
Merged

feat(alerts): Add migration warnings on detail and edit view #58431

merged 2 commits into from
Oct 19, 2023

Conversation

ArthurKnaus
Copy link
Member

@ArthurKnaus ArthurKnaus requested a review from a team October 19, 2023 13:45
@ArthurKnaus ArthurKnaus requested a review from a team as a code owner October 19, 2023 13:45
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 19, 2023
scttcper
scttcper reviewed Oct 19, 2023
View reviewed changes
static/app/views/alerts/rules/metric/ruleForm.tsx
Comment on lines +1060 to +1062
<Button size="xs" type="submit">
{t('Looks good to me!')}
</Button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does submit do something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BE takes care that the dataset is updated to generic_metrics once an alert is being saved.

@ArthurKnaus ArthurKnaus merged commit 09bdc62 into master Oct 19, 2023
@ArthurKnaus ArthurKnaus deleted the aknaus/feat/alerts/add-migration-warning-on-rule-details branch October 19, 2023 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

@RaduW RaduW RaduW approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration UI
3 participants
@ArthurKnaus @scttcper @RaduW