Skip to content

chore(alerts): Clean up rate limiting flag references #60483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

isabellaenriquez
Copy link
Member

@isabellaenriquez isabellaenriquez commented Nov 22, 2023

The metric alert rate limiting flag has been turned on for all orgs for a couple of weeks now and is working as expected, so we can remove the flag. Part of #58648

Will follow up with a PR to remove the flag entirely

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 22, 2023
@isabellaenriquez isabellaenriquez marked this pull request as ready for review November 22, 2023 19:51
@isabellaenriquez isabellaenriquez requested a review from a team as a code owner November 22, 2023 19:51
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #60483 (7b2c620) into master (dcd8f4f) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #60483   +/-   ##
=======================================
  Coverage   80.84%   80.85%           
=======================================
  Files        5181     5181           
  Lines      227681   227743   +62     
  Branches    38325    38324    -1     
=======================================
+ Hits       184067   184132   +65     
+ Misses      37990    37988    -2     
+ Partials     5624     5623    -1     
Files Coverage Δ
src/sentry/incidents/subscription_processor.py 89.41% <100.00%> (-0.03%) ⬇️

... and 37 files with indirect coverage changes

@isabellaenriquez isabellaenriquez changed the title chore(alerts): Remove rate limiting flag references chore(alerts): Clean up rate limiting flag references Nov 22, 2023
@isabellaenriquez isabellaenriquez merged commit 0df8a3d into master Nov 22, 2023
@isabellaenriquez isabellaenriquez deleted the isabella/remove-metric-alert-limit-flag-ref branch November 22, 2023 22:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants