Skip to content

chore(alerts): Remove metric alert rate limiting flag #60487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

isabellaenriquez
Copy link
Member

Follow up to #60483

Closes #58648

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #60487 (7e665c1) into master (bb1cbec) will increase coverage by 0.00%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #60487   +/-   ##
=======================================
  Coverage   80.87%   80.87%           
=======================================
  Files        5183     5183           
  Lines      227519   227496   -23     
  Branches    38251    38244    -7     
=======================================
- Hits       183996   183984   -12     
+ Misses      37901    37892    -9     
+ Partials     5622     5620    -2     
Files Coverage Δ
src/sentry/conf/server.py 90.00% <ø> (ø)
src/sentry/features/__init__.py 100.00% <ø> (ø)
.../components/onboardingWizard/useOnboardingDocs.tsx 70.37% <ø> (-1.98%) ⬇️
...c/app/components/performanceOnboarding/sidebar.tsx 68.60% <ø> (+0.78%) ⬆️
...ProfilingOnboarding/profilingOnboardingSidebar.tsx 30.00% <ø> (ø)
...tatic/app/components/replaysOnboarding/sidebar.tsx 26.53% <ø> (+0.53%) ⬆️

... and 6 files with indirect coverage changes

Base automatically changed from isabella/remove-metric-alert-limit-flag-ref to master November 22, 2023 22:11
@isabellaenriquez isabellaenriquez marked this pull request as ready for review November 27, 2023 17:26
@isabellaenriquez isabellaenriquez requested a review from a team November 27, 2023 17:27
@isabellaenriquez isabellaenriquez merged commit 3a323b4 into master Nov 27, 2023
@isabellaenriquez isabellaenriquez deleted the isabella/remove-metric-alert-limit-flag branch November 27, 2023 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove flag for metric alert rate limiting
2 participants