feat(feedback): set feedback issue to ignored if spam #69479
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69479 +/- ##
===========================================
+ Coverage 61.35% 78.72% +17.37%
===========================================
Files 6456 6469 +13
Lines 287024 287208 +184
Branches 49480 49493 +13
===========================================
+ Hits 176101 226116 +50015
+ Misses 110357 60670 -49687
+ Partials 566 422 -144
|
| @@ -240,6 +241,16 @@ def create_feedback_issue(event, project_id, source: FeedbackCreationSource): | |||
| produce_occurrence_to_kafka( | |||
| payload_type=PayloadType.OCCURRENCE, occurrence=occurrence, event_data=event_fixed | |||
| ) | |||
| if is_message_spam: | |||
| produce_occurrence_to_kafka( | |||
There was a problem hiding this comment.
Not sure if this is the bug you're referring to but is it possible for this message to be processed before the PayloadType.OCCURRENCE message? would the group not exist in that case?
There was a problem hiding this comment.
yes, that's the bug i'm referring to, and that's what steve is fixing here: #69466
|
- If the message is spam, set it to be ignored by producing a status change message to the occurrence consumer. There is not a way currently to set an issues state to ignored upon creation, but this should set it to ignored pretty close to immediate. Note that there is sometimes buggy with issue occurrence messages sometimes processed out of order, but there is some ongoing work with issue platform to fix this soon.
There is not a way currently to set an issues state to ignored upon creation, but this should set it to ignored pretty close to immediate.
Note that there is sometimes buggy with issue occurrence messages sometimes processed out of order, but there is some ongoing work with issue platform to fix this soon.