Skip to content

chore(replay/issues): add issue_replay_inline_onboarding to prompts config #69513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Apr 23, 2024

SCR-20240423-jmxe

@michellewzhang michellewzhang requested review from a team April 23, 2024 17:22
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 23, 2024
@michellewzhang michellewzhang merged commit cfb6695 into master Apr 23, 2024
51 checks passed
@michellewzhang michellewzhang deleted the mz/prompt-issue branch April 23, 2024 17:52
armenzg pushed a commit that referenced this pull request Apr 24, 2024
…onfig (#69513)

- Relates to #69207
- Will be used to update the dismiss mechanism of the issue details
replay inline onboarding banner
- Added `project_id` as a required field since we want to store the
dismissal across project

<img width="863" alt="SCR-20240423-jmxe"
src="https://github.com/getsentry/sentry/assets/56095982/a9e1efc3-3325-4669-9a9b-d44dda66fcda">
michellewzhang added a commit that referenced this pull request Apr 24, 2024
…mpt dismiss (#69525)

- followup from #69513
- closes #69207
- update the issue details replay inline onboarding CTA to use prompt
dismiss instead of `useDismissAlert`
- behavior should still be the same: snooze is 7 days, dismiss is
forever
- also made some updates to `usePrompt` hook to allow for snoozing


![image](https://github.com/getsentry/sentry/assets/56095982/93541900-5df6-4da9-ab14-0af54cda7575)
MichaelSun48 pushed a commit that referenced this pull request Apr 25, 2024
…onfig (#69513)

- Relates to #69207
- Will be used to update the dismiss mechanism of the issue details
replay inline onboarding banner
- Added `project_id` as a required field since we want to store the
dismissal across project

<img width="863" alt="SCR-20240423-jmxe"
src="https://github.com/getsentry/sentry/assets/56095982/a9e1efc3-3325-4669-9a9b-d44dda66fcda">
MichaelSun48 pushed a commit that referenced this pull request Apr 25, 2024
…mpt dismiss (#69525)

- followup from #69513
- closes #69207
- update the issue details replay inline onboarding CTA to use prompt
dismiss instead of `useDismissAlert`
- behavior should still be the same: snooze is 7 days, dismiss is
forever
- also made some updates to `usePrompt` hook to allow for snoozing


![image](https://github.com/getsentry/sentry/assets/56095982/93541900-5df6-4da9-ab14-0af54cda7575)
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants