Skip to content

style(feedback): allow url to scroll rather than wrap #72985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2024
Merged

style(feedback): allow url to scroll rather than wrap #72985

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1bb7ae
style(feedback): allow url to scroll rather than wrap
michellewzhang Jun 18, 2024
6a478a2
:recycle: check if url is link before opening modal
michellewzhang Jun 20, 2024
899e072
Update static/app/components/feedback/feedbackItem/feedbackItem.tsx
michellewzhang Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 14 additions & 26 deletions static/app/components/feedback/feedbackItem/feedbackItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {Fragment, useEffect, useRef} from 'react';
import {useTheme} from '@emotion/react';
import styled from '@emotion/styled';

import {openNavigateToExternalLinkModal} from 'sentry/actionCreators/modal';
Expand All @@ -10,9 +11,9 @@ import Section from 'sentry/components/feedback/feedbackItem/feedbackItemSection
import FeedbackReplay from 'sentry/components/feedback/feedbackItem/feedbackReplay';
import MessageSection from 'sentry/components/feedback/feedbackItem/messageSection';
import TagsSection from 'sentry/components/feedback/feedbackItem/tagsSection';
import ExternalLink from 'sentry/components/links/externalLink';
import PanelItem from 'sentry/components/panels/panelItem';
import QuestionTooltip from 'sentry/components/questionTooltip';
import TextCopyInput from 'sentry/components/textCopyInput';
import {IconChat, IconFire, IconLink, IconTag} from 'sentry/icons';
import {t} from 'sentry/locale';
import {space} from 'sentry/styles/space';
Expand All @@ -32,6 +33,7 @@ export default function FeedbackItem({feedbackItem, eventData, tags}: Props) {
eventData?.contexts.feedback?.url ??
eventData?.tags.find(tag => tag.key === 'url')?.value;
const crashReportId = eventData?.contexts?.feedback?.associated_event_id;
const theme = useTheme();

const overflowRef = useRef<HTMLDivElement>(null);
useEffect(() => {
Expand All @@ -53,24 +55,17 @@ export default function FeedbackItem({feedbackItem, eventData, tags}: Props) {

{!crashReportId || (crashReportId && url) ? (
<Section icon={<IconLink size="xs" />} title={t('URL')}>
<UrlWrapper>
{eventData?.contexts.feedback || eventData?.tags ? (
url ? (
<ExternalLink
onClick={e => {
e.preventDefault();
openNavigateToExternalLinkModal({linkText: url});
}}
>
{url}
</ExternalLink>
) : (
t('URL not found')
)
) : (
''
)}
</UrlWrapper>
<TextCopyInput
style={{color: `${theme.blue400}`}}
onClick={e => {
e.preventDefault();
openNavigateToExternalLinkModal({linkText: url});
}}
>
{eventData?.contexts.feedback || eventData?.tags
? url ?? t('URL not found')
: ''}
</TextCopyInput>
</Section>
) : null}

Expand Down Expand Up @@ -126,10 +121,3 @@ const OverflowPanelItem = styled(PanelItem)`
gap: ${space(2)};
padding: ${space(2)} ${space(2)} 0 ${space(2)};
`;

const UrlWrapper = styled('div')`
border-radius: ${p => p.theme.borderRadius};
border: 1px solid ${p => p.theme.border};
padding: ${space(0.75)} ${space(1.5)};
line-height: 1.3em;
`;
Loading