-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
style(feedback): allow url to scroll rather than wrap #72985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bundle ReportChanges will increase total bundle size by 14.67kB ⬆️
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72985 +/- ##
==========================================
- Coverage 77.05% 77.03% -0.02%
==========================================
Files 6606 6608 +2
Lines 294516 294727 +211
Branches 50770 50803 +33
==========================================
+ Hits 226938 227043 +105
- Misses 61114 61285 +171
+ Partials 6464 6399 -65
|
Co-authored-by: Ryan Albrecht <[email protected]>
same logic, just using the
TextCopyInput
component now, which allows us to scroll, copy, & still click and go to an external link.before:
Screen.Recording.2024-06-18.at.4.12.02.PM.mov
after:
Screen.Recording.2024-06-18.at.4.38.17.PM.mov
url not found - no modal:
Screen.Recording.2024-06-20.at.9.46.14.AM.mov
no url - no modal:
Screen.Recording.2024-06-20.at.9.46.00.AM.mov