Skip to content

style(feedback): allow url to scroll rather than wrap #72985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Jun 18, 2024

same logic, just using the TextCopyInput component now, which allows us to scroll, copy, & still click and go to an external link.

before:

Screen.Recording.2024-06-18.at.4.12.02.PM.mov

SCR-20240618-ogpc

after:

Screen.Recording.2024-06-18.at.4.38.17.PM.mov

url not found - no modal:

Screen.Recording.2024-06-20.at.9.46.14.AM.mov

no url - no modal:

Screen.Recording.2024-06-20.at.9.46.00.AM.mov

@michellewzhang michellewzhang requested a review from a team as a code owner June 18, 2024 23:40
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Bundle Report

Changes will increase total bundle size by 14.67kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.31MB 14.67kB ⬆️

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.03%. Comparing base (fce0b9b) to head (6a478a2).
Report is 97 commits behind head on master.

Current head 6a478a2 differs from pull request most recent head 899e072

Please upload reports for the commit 899e072 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72985      +/-   ##
==========================================
- Coverage   77.05%   77.03%   -0.02%     
==========================================
  Files        6606     6608       +2     
  Lines      294516   294727     +211     
  Branches    50770    50803      +33     
==========================================
+ Hits       226938   227043     +105     
- Misses      61114    61285     +171     
+ Partials     6464     6399      -65     
Files Coverage Δ
.../components/feedback/feedbackItem/feedbackItem.tsx 0.00% <0.00%> (ø)

... and 319 files with indirect coverage changes

@michellewzhang michellewzhang requested a review from ryan953 June 20, 2024 16:49
@michellewzhang michellewzhang merged commit bdc113c into master Jun 20, 2024
40 of 41 checks passed
@michellewzhang michellewzhang deleted the mz/fb-scroll-url branch June 20, 2024 18:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants