Skip to content

feat(feedback): add BE prompt for hiding feedback from issue details #74219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024
Merged

feat(feedback): add BE prompt for hiding feedback from issue details #74219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/utils/prompts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"data_consent_banner": {"required_fields": ["organization_id"]},
"data_consent_priority": {"required_fields": ["organization_id"]},
"issue_replay_inline_onboarding": {"required_fields": ["organization_id", "project_id"]},
"issue_feedback_hidden": {"required_fields": ["organization_id", "project_id"]},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we renamed it to something like issue_user_feedback? the trend seems to be that the names should be more related to the component rather than the action

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the _hidden makes it more clear what the component is using this prompt for

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think all prompts are used for hiding/dismissing something tho, it's implied but im not super adamant on it

}


Expand Down
Loading