ref(control_silo): Move UserAvatar model to users module #76190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of moving control silo user related resources into the users module, this PR does not include an old UserRole import shim as it's not used in getsentry. Includes adding of types for functions. Apart of (#73856)
github-actions
bot
added
the
Scope: Backend
Christinarlong
commented
Aug 14, 2024
There was a problem hiding this comment.
Broke test_avatar into these two files
test_organization_avatartest_user_avatar
Christinarlong
commented
Aug 14, 2024
| @@ -63,7 +63,7 @@ def outboxes_for_update(self, shard_identifier: int | None = None) -> list[Contr | |||
| ) | |||
|
|
|||
| @contextlib.contextmanager | |||
| def _maybe_prepare_outboxes(self, *, outbox_before_super: bool): | |||
| def _maybe_prepare_outboxes(self, *, outbox_before_super: bool) -> Generator[None]: | |||
There was a problem hiding this comment.
Not rlly familiar with the convention here, should this be `Generator[None, None, None] from following this, or does it not matter ?
There was a problem hiding this comment.
Generator[None] is the simpler form and one we should use. Recently all Generator[none, none, none] were updated. See 16b7563
markstory
approved these changes
Aug 14, 2024
| @@ -63,7 +63,7 @@ def outboxes_for_update(self, shard_identifier: int | None = None) -> list[Contr | |||
| ) | |||
|
|
|||
| @contextlib.contextmanager | |||
| def _maybe_prepare_outboxes(self, *, outbox_before_super: bool): | |||
| def _maybe_prepare_outboxes(self, *, outbox_before_super: bool) -> Generator[None]: | |||
There was a problem hiding this comment.
Generator[None] is the simpler form and one we should use. Recently all Generator[none, none, none] were updated. See 16b7563
Christinarlong
deleted the
christinarlong/consolidate-users-models-useravatar
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of moving control silo user related resources into the users module, this PR does not include an old UserRole import shim as it's not used in getsentry. Includes adding of types for functions.
Apart of (#73856)