App Modules - Consolidate User resources #73856

markstory · 2024-07-04T20:23:42Z

User and its direct relations are control_silo scoped resources. Currently the components that comprise the control silo aspects of users are spread throughout the repository. Consolidating those classes and functions into sentry.users will help clarify the application's design and make running subsets of tests easier and faster.

Communicate these changes with the broader ecosystem team
Move endpoints, serializers, models, and tasks to be co-located.

We'll need to provide import shims for any symbols used in getsentry until those imports can be updated separately. Furthremore, within django shell we should preserve sentry.models.User as an import.

cc @Christinarlong

The text was updated successfully, but these errors were encountered:

Moves all User and authenticator specific models and tests to their own directories. ref(#73856)

Move email model to the users module and leave shim for getsentry. ref(#73856) --------- Co-authored-by: Mark Story <[email protected]>

) Part of moving control silo user related resources into the users module. Includes adding of types for the user model functions. Apart of (#73856) --------- Co-authored-by: Mark Story <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Part of moving control silo user related resources into the users module. Includes adding of types for functions. Apart of (#73856)

…5597) Part of consolidating (user) control silo resources to be located with other user related models. Leaves behind a shim for any getsentry references. Also includes a fix for backfill_outboxes to ensure batch.count doesn't become negative which caused tests in test_backfill_outboxes to fail. Ref(#73856) --------- Co-authored-by: Mark Story <[email protected]>

Part of moving control silo user related resources into the users module, this PR does not include an old UserRole import shim as it's not used in getsentry. Includes adding of types for functions. Apart of (#73856)

…5597) Part of consolidating (user) control silo resources to be located with other user related models. Leaves behind a shim for any getsentry references. Also includes a fix for backfill_outboxes to ensure batch.count doesn't become negative which caused tests in test_backfill_outboxes to fail. Ref(#73856) --------- Co-authored-by: Mark Story <[email protected]>

Part of moving control silo user related resources into the users module. Includes adding of types for functions. Apart of (#73856)

Part of moving control silo user related resources into the users module. Includes adding import shim for any getsentry refs. Apart of (#73856)

Part of moving control silo user related resources into the usersmodule, this PR does not include an old UserRole import shim as it's not used in getsentry. Includes adding of types for functions. Apart of (#73856)

Part of moving control silo user related resources into the users module, this PR does not include an old UserRole import shim as it's not used in getsentry. Includes adding of types for functions. Apart of (#73856)

Part of moving control silo user related resources into the users module. Includes adding of types for functions and an import shim for any getsentry refs. Apart of (#73856) --------- Co-authored-by: Mark Story <[email protected]>

Part of moving control silo user related resources into the users module, this PR does not include an old UserIp import shim as it's not used in getsentry. Includes adding of types for functions. Apart of (#73856)

Part of moving control silo user related resources into the users module. Includes adding any missing types for the model. Apart of (#73856)

Part of moving control silo user related resources into the users module. Includes adding import shim for any getsentry refs. Apart of (#73856)

Part of moving control silo user related resources into the usersmodule. Includes adding import shim for any getsentry refs. Apart of (#73856)

Part of moving control silo user related resources into the users module, this PR does not include an old UserIP import shim as the UserIP model is not used in getsentry. Includes adding of types for functions. Apart of (#73856)

Part of moving control silo user related resources into the users module. Includes adding import shim for any getsentry refs. Apart of (#73856)

Part of moving control silo user related resources into the users module, this PR does not include an old UserRole import shim as it's not used in getsentry. Includes adding of types for functions. Apart of (#73856)

Part of moving control silo user related resources into the usersmodule. Includes adding import shim for any getsentry refs. Also addsminor typing to some identity functions. Apart of (#73856)

Part of moving control silo user related resources into the users module. Moves endpoints & tests and updates and refs. Apart of (#73856)

Part of moving control silo user related resources into the users module. Moves endpoints & tests and updates and refs. Apart of (#73856) --------- Co-authored-by: Mark Story <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Moves rest of user's serializers to the user's directory - UserIP - UserRole - Identity - IdentitiyProvider - UserEmail Adds typing - mainly serializer response dicts to the serializers split of (#76822) ref(#73856 )

Issue ref(#73856 )

Update the CODEOWNERS, mainly update moved filepaths Issue ref (#73856) --------- Co-authored-by: Mark Story <[email protected]>

Moves rest of user's serializers to the user's directory - UserIP - UserRole - Identity - IdentitiyProvider - UserEmail Adds typing - mainly serializer response dicts to the serializers split of (#76822) ref(#73856 )

Issue ref(#73856 )

Update the CODEOWNERS, mainly update moved filepaths Issue ref (#73856) --------- Co-authored-by: Mark Story <[email protected]>

…w abode (#76896) split of (#76822) Issue ref(#73856 )

what if we deleted the user shims since getsentry refs are updated and updated any missed import paths ref(#73856)

issue ref(#73856)

Remove bases shim & add barrel file for users models. Looks like if you use a ForeignKeyRef in a model, django stubs won't be able to recognize it unless there exists a barrel file. issue ref(#73856) --------- Co-authored-by: Mark Story <[email protected]>

markstory · 2024-10-17T18:44:13Z

Closing as we've finished users off.

Christinarlong added a commit that referenced this issue Jul 12, 2024

ref(control_silo): Consolidate User models (and authenticator) and tests

d390263

Moves all User and authenticator specific models and tests to their own directories. ref(#73856)

Christinarlong mentioned this issue Jul 12, 2024

ref(control_silo): Consolidate User models (and authenticator) and tests #74222

Closed

This was referenced Aug 5, 2024

chore(control_silo): Move User model to new home in users package #75597

Merged

ref(control_silo): Move over Authenticator model to Users module #75857

Merged

ref(control_silo): Move Email model to Users module #75915

Merged

Christinarlong added a commit that referenced this issue Aug 9, 2024

ref(control_silo): Move Email model to Users module (#75915)

e701623

Move email model to the users module and leave shim for getsentry. ref(#73856) --------- Co-authored-by: Mark Story <[email protected]>

Christinarlong added a commit that referenced this issue Aug 13, 2024

ref(control_silo): Move LostPasswordHash to users module

d911aec

Part of moving control silo user related resources into the users module. Includes adding of types for functions. Apart of (#73856)

Christinarlong mentioned this issue Aug 13, 2024

ref(control_silo): Move LostPasswordHash to users module #76072

Merged

Christinarlong mentioned this issue Aug 13, 2024

ref(control_silo): Move UserRole model to users module #76125

Merged

Christinarlong added a commit that referenced this issue Aug 13, 2024

ref(control_silo): Move UserEmail model to users module

3d38669

Part of moving control silo user related resources into the users module. Includes adding of types for functions. Apart of (#73856)

Christinarlong mentioned this issue Aug 13, 2024

ref(control_silo): Move UserEmail model to users module #76134

Merged

Christinarlong added a commit that referenced this issue Aug 13, 2024

ref(control_silo): Move UserPermission model to users module

a39474c

Part of moving control silo user related resources into the users module. Includes adding import shim for any getsentry refs. Apart of (#73856)

Christinarlong mentioned this issue Aug 13, 2024

ref(control_silo): Move UserPermission model to users module #76145

Merged

Christinarlong mentioned this issue Aug 14, 2024

ref(control_silo): Move UserAvatar model to users module #76190

Merged

Christinarlong mentioned this issue Aug 14, 2024

ref(control_silo): Move UserIP model to users module #76202

Merged

Christinarlong added a commit that referenced this issue Aug 14, 2024

ref(control_silo): Move UserEmail model to users module (#76134)

02abec0

Part of moving control silo user related resources into the users module. Includes adding any missing types for the model. Apart of (#73856)

Christinarlong added a commit that referenced this issue Aug 14, 2024

ref(control_silo): Move UserOption model to users module

2c073f9

Part of moving control silo user related resources into the users module. Includes adding import shim for any getsentry refs. Apart of (#73856)

Christinarlong mentioned this issue Aug 14, 2024

ref(control_silo): Move UserOption model to users module #76231

Merged

Christinarlong added a commit that referenced this issue Aug 14, 2024

ref(control_silo): Move UserReport model to users module

570aebc

Part of moving control silo user related resources into the users module. Includes adding import shim for any getsentry refs. Apart of (#73856)

This was referenced Aug 14, 2024

ref(control_silo): Move UserReport model to users module #76238

Closed

ref(control_silo): Move Identitiy model to users module #76272

Merged

Christinarlong added a commit that referenced this issue Aug 15, 2024

ref(control_silo): Move UserPermission model to users module (#76145)

7a1c29e

Part of moving control silo user related resources into the usersmodule. Includes adding import shim for any getsentry refs. Apart of (#73856)

Christinarlong added a commit that referenced this issue Aug 15, 2024

ref(control_silo): Move UserOption model to users module (#76231)

d8ecb26

Part of moving control silo user related resources into the users module. Includes adding import shim for any getsentry refs. Apart of (#73856)

Christinarlong added a commit that referenced this issue Aug 16, 2024

ref(control_silo): Move various users endpoints to users module

9dba4e4

Part of moving control silo user related resources into the users module. Moves endpoints & tests and updates and refs. Apart of (#73856)

Christinarlong mentioned this issue Aug 16, 2024

ref(control_silo): Move various users endpoints to users module #76341

Merged

Christinarlong added a commit that referenced this issue Sep 9, 2024

ref(users): move users related web resources to users directory (#76981)

1c926eb

Issue ref(#73856 )

Christinarlong added a commit that referenced this issue Sep 9, 2024

chore(users): update codeowners for users modules (#77196)

f119484

Update the CODEOWNERS, mainly update moved filepaths Issue ref (#73856) --------- Co-authored-by: Mark Story <[email protected]>

c298lee pushed a commit that referenced this issue Sep 10, 2024

ref(users): move users related web resources to users directory (#76981)

6fa9d26

Issue ref(#73856 )

c298lee pushed a commit that referenced this issue Sep 10, 2024

chore(users): update codeowners for users modules (#77196)

49e5430

Update the CODEOWNERS, mainly update moved filepaths Issue ref (#73856) --------- Co-authored-by: Mark Story <[email protected]>

Christinarlong added a commit that referenced this issue Sep 10, 2024

ref(users): move user & user_identity_config & auth serializers to ne…

1c2e8a6

…w abode (#76896) split of (#76822) Issue ref(#73856 )

Christinarlong mentioned this issue Sep 10, 2024

chore(users): cleaning up them users shims #77283

Merged

Christinarlong added a commit that referenced this issue Sep 11, 2024

chore(users): cleaning up them users shims (#77283)

c2d3da9

what if we deleted the user shims since getsentry refs are updated and updated any missed import paths ref(#73856)

mifu67 pushed a commit that referenced this issue Sep 12, 2024

chore(users): cleaning up them users shims (#77283)

2dec161

what if we deleted the user shims since getsentry refs are updated and updated any missed import paths ref(#73856)

Christinarlong mentioned this issue Sep 13, 2024

chore(users): Move User base endpoint file to users directory #77501

Merged

Christinarlong added a commit that referenced this issue Sep 13, 2024

chore(users): Move User base endpoint file to users directory (#77501)

ff9a79b

issue ref(#73856)

Christinarlong mentioned this issue Sep 16, 2024

chore(users): Remove bases shim #77569

Merged

markstory closed this as completed Oct 17, 2024

github-actions bot locked and limited conversation to collaborators Nov 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

App Modules - Consolidate User resources #73856

App Modules - Consolidate User resources #73856

markstory commented Jul 4, 2024 •

edited

Loading

markstory commented Oct 17, 2024

Uh oh!

Uh oh!

App Modules - Consolidate User resources #73856

App Modules - Consolidate User resources #73856

Comments

markstory commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

markstory commented Oct 17, 2024

Uh oh!

markstory commented Jul 4, 2024 •

edited

Loading