Skip to content

ref(control_silo): Move UserIP model to users module #76202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

Christinarlong
Copy link
Contributor

Part of moving control silo user related resources into the users module, this PR does not include an old UserIP import shim as the UserIP model is not used in getsentry. Includes adding of types for functions.

Apart of (#73856)

Part of moving control silo user related resources into the users module, this PR does not include an old UserIp import shim as it's not used in getsentry. Includes adding of types for functions.

Apart of (#73856)
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 14, 2024
@Christinarlong Christinarlong marked this pull request as ready for review August 14, 2024 20:04
@Christinarlong Christinarlong requested a review from a team August 14, 2024 20:04
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Christinarlong Christinarlong merged commit 8c8eb25 into master Aug 15, 2024
49 checks passed
@Christinarlong Christinarlong deleted the christinarlong/consolidate-users-models-userip branch August 15, 2024 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants