-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(users): move users related web resources to users directory #76981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves user related web resources and adds typing where needed. ref(issue # here)
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #76981 +/- ##
==========================================
+ Coverage 78.22% 78.25% +0.02%
==========================================
Files 6898 6901 +3
Lines 306690 307146 +456
Branches 50276 50326 +50
==========================================
+ Hits 239913 240344 +431
- Misses 60415 60427 +12
- Partials 6362 6375 +13 |
markstory
approved these changes
Sep 5, 2024
markstory
reviewed
Sep 5, 2024
|
||
audit_logger = logging.getLogger("sentry.audit.user") | ||
delete_logger = logging.getLogger("sentry.deletions.api") | ||
|
||
|
||
def _get_timezone_choices() -> list[tuple[str, str]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job consolidating this with its clone 👏
c298lee
pushed a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves user related web resources and adds typing where needed.
ref(issue # here)