Skip to content

ref(users): move users related web resources to users directory #76981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

Christinarlong
Copy link
Contributor

@Christinarlong Christinarlong commented Sep 5, 2024

Moves user related web resources and adds typing where needed.

  • user_avatar & test_user_avatar
  • accounts & test_accounts
  • forms/accounts -> split into users/web/accounts_form.py & web/forms/accounts.py for user and auth related resources
  • tests/forms/test_accounts.py -> tests/users/web/account_forms.py (only contains user resource related tests so not split)
  • account_identity & test_account_identity

ref(issue # here)

Moves user related web resources and adds typing where needed.

ref(issue # here)
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 86.08696% with 16 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/users/web/accounts_form.py 80.51% 13 Missing and 2 partials ⚠️
src/sentry/users/web/accounts.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #76981      +/-   ##
==========================================
+ Coverage   78.22%   78.25%   +0.02%     
==========================================
  Files        6898     6901       +3     
  Lines      306690   307146     +456     
  Branches    50276    50326      +50     
==========================================
+ Hits       239913   240344     +431     
- Misses      60415    60427      +12     
- Partials     6362     6375      +13     


audit_logger = logging.getLogger("sentry.audit.user")
delete_logger = logging.getLogger("sentry.deletions.api")


def _get_timezone_choices() -> list[tuple[str, str]]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job consolidating this with its clone 👏

@Christinarlong Christinarlong marked this pull request as ready for review September 9, 2024 19:39
@Christinarlong Christinarlong requested review from a team as code owners September 9, 2024 19:39
@Christinarlong Christinarlong merged commit 1c926eb into master Sep 9, 2024
53 of 54 checks passed
@Christinarlong Christinarlong deleted the christinarlong/consolidate-user-web branch September 9, 2024 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants