ref(uptime): Make subscription unique on timeout as well #78787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout will become configurable, so we need subscriptions to be unique on this additional facet.
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Remove constraint uptime_uptimesubscription_unique_subscription_check from model uptimesubscription
--
DROP INDEX CONCURRENTLY IF EXISTS "uptime_uptimesubscription_unique_subscription_check";
--
-- Create constraint uptime_uptimesubscription_unique_subscription_check on model uptimesubscription
--
CREATE UNIQUE INDEX CONCURRENTLY "uptime_uptimesubscription_unique_subscription_check" ON "uptime_uptimesubscription" ("url", "interval_seconds", "timeout_ms", "method", (MD5("headers")), (COALESCE(MD5("body"), ''))); |
wedamija
approved these changes
Oct 8, 2024
evanpurkhiser
deleted the
evanpurkhiser/ref-uptime-make-subscription-unique-on-timeout-as-well
branch
evanpurkhiser
added a commit
that referenced
this pull request
Oct 15, 2024
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout will become configurable, so we need subscriptions to be
unique on this additional facet.