feat(uptime): Accept timeout customization in uptime APIs #78788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #78788 +/- ##
==========================================
- Coverage 78.29% 78.29% -0.01%
==========================================
Files 7132 7133 +1
Lines 313960 314193 +233
Branches 51265 51320 +55
==========================================
+ Hits 245820 246001 +181
- Misses 61711 61757 +46
- Partials 6429 6435 +6 |
wedamija
approved these changes
Oct 8, 2024
| @@ -27,7 +27,7 @@ interface Props { | |||
| } | |||
|
|
|||
| export function DetailsTimeline({monitor, organization}: Props) { | |||
| const {location} = useRouter(); | |||
| const location = useLocation(); | |||
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-uptime-accept-timeout-customization-in-uptime-apis
branch
from
3e75160 to
d17d336
Compare
Bundle ReportChanges will decrease total bundle size by 44 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
evanpurkhiser
deleted the
evanpurkhiser/feat-uptime-accept-timeout-customization-in-uptime-apis
branch
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #78787
Requires #78782