Move incrementation of Device::last_acceleration_structure_build_command_index into queue submit
#7462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
I think this code looks fine - would it be possible to rebase into two commits, one for the submission index change, then one for the rest of the RT stuff. Due to how finicky this stuff is, the submission change being isolated would be good for bisection.
Conditionally approving.
|
I'm not entirely sure how to do that, but I'll try. |
Vecvec
force-pushed
the
fix-build-load
branch
2 times, most recently
from
5696a3e to
aa3c69d
Compare
|
Does this work better? Edit: Nvm still need to fix CI. |
Vecvec
force-pushed
the
fix-build-load
branch
3 times, most recently
from
aaa29d6 to
a4ca035
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #5978 as well
Description
Previously, the acceleration structure build command index was incremented at the start of a build, but in certain cases (one is demonstrated by the test) this could cause odd issues. The first idea was to increment it at build submit, but that ran into a similar issue to #5978. Since the solution required the same things as queue submit I ended up fixing that too. Though I can remove that fix if it is wanted.
Testing
Adds a test for this
Squash or Rebase?
Squash
Checklist
cargo fmt.cargo clippy --tests. If applicable, add:cargo xtask testto run tests.CHANGELOG.mdentry.