mingw: drop bogus (and unneeded) declaration of _pgmptr

[dscho]

Ran into this in https://github.com/git-for-windows/git-sdk-64/actions/runs/9558244721/job/26346637793.

cc: Mike Hommey [email protected]

[dscho]

/submit

[gitgitgadget]

Submitted as [email protected]

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1752/dscho/drop-bogus-_pgmptr-declaration-v1

To fetch this version to local tag pr-1752/dscho/drop-bogus-_pgmptr-declaration-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1752/dscho/drop-bogus-_pgmptr-declaration-v1

[gitgitgadget]

On the Git mailing list, Mike Hommey wrote (reply to this):

On Wed, Jun 19, 2024 at 06:09:58AM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <[email protected]>
> 
> In 08809c09aa13 (mingw: add a helper function to attach GDB to the
> current process, 2020-02-13), I added a declaration that was not needed.
> Back then, that did not matter, but now that the declaration of that
> symbol was changed in mingw-w64's headers, it causes the following
> compile error:
> 
>       CC compat/mingw.o
>   compat/mingw.c: In function 'open_in_gdb':
>   compat/mingw.c:35:9: error: function declaration isn't a prototype [-Werror=strict-prototypes]
>      35 |         extern char *_pgmptr;
>         |         ^~~~~~
>   In file included from C:/git-sdk-64/usr/src/git/build-installers/mingw64/lib/gcc/x86_64-w64-mingw32/14.1.0/include/mm_malloc.h:27,
>                    from C:/git-sdk-64/usr/src/git/build-installers/mingw64/lib/gcc/x86_64-w64-mingw32/14.1.0/include/xmmintrin.h:34,
>                    from C:/git-sdk-64/usr/src/git/build-installers/mingw64/lib/gcc/x86_64-w64-mingw32/14.1.0/include/immintrin.h:31,
>                    from C:/git-sdk-64/usr/src/git/build-installers/mingw64/lib/gcc/x86_64-w64-mingw32/14.1.0/include/x86intrin.h:32,
>                    from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/winnt.h:1658,
>                    from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/minwindef.h:163,
>                    from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/windef.h:9,
>                    from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/windows.h:69,
>                    from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/winsock2.h:23,
>                    from compat/../git-compat-util.h:215,
>                    from compat/mingw.c:1:
>   compat/mingw.c:35:22: error: '__p__pgmptr' redeclared without dllimport attribute: previous dllimport ignored [-Werror=attributes]
>      35 |         extern char *_pgmptr;
>         |                      ^~~~~~~
> 
> Let's just drop the declaration and get rid of this compile error.

I can only suppose it gets rid of the compiler error with close to 100%
certainty because for some reason, it only happens intermittently for me
and I don't know whether I'm lucky or if the issue is fixed for real,
but what it absolutely sure is that it doesn't break anything.

Mike

[gitgitgadget]

User Mike Hommey <[email protected]> has been added to the cc: list.

[gitgitgadget]

On the Git mailing list, Junio C Hamano wrote (reply to this):

Mike Hommey <[email protected]> writes:

> I can only suppose it gets rid of the compiler error with close to 100%
> certainty because for some reason, it only happens intermittently for me
> and I don't know whether I'm lucky or if the issue is fixed for real,
> but what it absolutely sure is that it doesn't break anything.

That is a curious vote of confidence ;-)  Will queue.  Thanks, both.

[gitgitgadget]

This branch is now known as js/mingw-remove-unused-extern-decl.

[gitgitgadget]

This patch series was integrated into seen via git@06ec1e8.

[gitgitgadget]

This patch series was integrated into next via git@65b3239.

[gitgitgadget]

There was a status update in the "New Topics" section about the branch js/mingw-remove-unused-extern-decl on the Git mailing list:

An unused extern declaration for mingw has been removed to prevent
it from causing build failure.

Will merge to 'master'.
source: <[email protected]>

[gitgitgadget]

This patch series was integrated into seen via git@5257207.

[gitgitgadget]

This patch series was integrated into seen via git@b62c197.

[gitgitgadget]

There was a status update in the "Cooking" section about the branch js/mingw-remove-unused-extern-decl on the Git mailing list:

An unused extern declaration for mingw has been removed to prevent
it from causing build failure.

Will merge to 'master'.
source: <[email protected]>

[gitgitgadget]

This patch series was integrated into seen via git@553af1f.

[gitgitgadget]

This patch series was integrated into seen via git@0b0307e.

[gitgitgadget]

This patch series was integrated into seen via git@55b59b6.

[gitgitgadget]

This patch series was integrated into seen via git@424a13d.

[gitgitgadget]

This patch series was integrated into master via git@424a13d.

[gitgitgadget]

This patch series was integrated into next via git@424a13d.

[gitgitgadget]

Closed via 424a13d.