Skip to content

fix(deps): downgrade to electron@19 to resolve macos code signing and startup crash #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Mar 20, 2024

Resolves #696

After exhaustive testing, electron@20 or higher causes the issue

Once merged, I'll mark the new Renovate electron@20 PR as requiring code changes to prevent macos startup crashes

@setchy setchy added bug Something isn't working dependency Dependency updates labels Mar 20, 2024
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work here!

@setchy setchy merged commit 747a4e9 into gitify-app:main Mar 20, 2024
7 checks passed
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
@setchy setchy deleted the bugfix/electron-version-downgrade branch April 7, 2024 11:42
@setchy setchy added this to the Release 5.0.0 milestone Jul 17, 2024
@setchy setchy removed the bug Something isn't working label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signing of v4.6.0 is broken
2 participants