Skip to content

Use ConfigCat to throttle adoption of PVC #12745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #7901
kylos101 opened this issue Sep 7, 2022 · 1 comment · Fixed by #13341
Closed
Tracked by #7901

Use ConfigCat to throttle adoption of PVC #12745

kylos101 opened this issue Sep 7, 2022 · 1 comment · Fixed by #13341
Assignees

Comments

@kylos101
Copy link
Contributor

kylos101 commented Sep 7, 2022

Is your feature request related to a problem? Please describe

Presently, we rely on a few things to determine if a workspace should start with PVC.

  1. They are restoring a workspace that previously used PVC (either from a prebuild or prior run of a regular workspace).
  2. A new workspace is being created, the user has the persistent_volume_claim feature flag enabled, while also being enabled for workspace classes.
  3. A new workspace is being created from the context of a prebuild workspace that was run with PVC (which can happen at least two ways, 1. the project has PVC enabled or 2. the prebuild workspace has the persistent_volume_claim feature flag persisted)

Describe the behaviour you'd like

For Case 2 (above), create a new configcat setting, and add a rule that uses Target % of users, which'll control the % of regular workspace starts that include the persistent_volume_claim feature flag. From a default perspective, for self-hosted, I think we'll want the new config setting to default to false, at least for now.

Case 1 should not need any changes. Case 3 is already covered by persistent_volume_claim (Prebuilds with Persistent Volume Claim) in configcat.

Then, in configcat, for both rules, we could be flexible with how we roll this out.

Internal conversation about how to configure rules in ConfigCat.

@kylos101
Copy link
Contributor Author

kylos101 commented Sep 9, 2022

Related: #12840

@sagor999 sagor999 moved this to In Progress in 🌌 Workspace Team Sep 26, 2022
@sagor999 sagor999 self-assigned this Sep 26, 2022
Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Oct 4, 2022
@jenting jenting moved this from Awaiting Deployment to In Validation in 🌌 Workspace Team Oct 5, 2022
@sagor999 sagor999 moved this from In Validation to Done in 🌌 Workspace Team Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants