allow to enable PVC feature flag for user via ConfigCat #13341
Conversation
| if ( | ||
| // ConfigCat already has feature flag named `persistent_volume_claim` that controls if we show | ||
| // the option to enable PVC for project prebuilds. So have to use a different name here. | ||
| await getExperimentsClientForBackend().getValueAsync("user_pvc", false, { |
There was a problem hiding this comment.
webapp team, when reviewing, can you double check that this is indeed the only place where I need to add this code?
There was a problem hiding this comment.
This change can actually go away, the other two are fine! 👍
But didn't find time to test, yet 😬
There was a problem hiding this comment.
Hm. Are you sure? Since I originally tested with this change only and it worked as expected. So want to double check before I remove this code. 🤔
There was a problem hiding this comment.
Are you sure?
Yes. That's the core of the PR from last week: persistent_volume_claim is a "workspace persistent" feature, so it should never be required to modify on start, only on creation.
This PR just changes the source from where we get the info from, so we should be able to simply follow all occurrences of user.featureFlags?.permanentWSFeatureFlags?.includes("persistent_volume_claim") and that check there (as you already did).
There was a problem hiding this comment.
@geropl ah, good to know. thank you! code removed. PTAL
|
started the job as gitpod-build-pavel-12745.1 because the annotations in the pull request description changed |
|
Starting review now... |
sagor999
force-pushed
the
pavel/12745
branch
from
b9b46ac to
c739640
Compare
|
@geropl updated code. Hopefully I did it the right way, not sure if adding all those injects all over the place is the correct way of doing it though. 😅 |
sagor999
force-pushed
the
pavel/12745
branch
from
c739640 to
d10be7f
Compare
|
@geropl PTAL |
roboquat
added
deployed: webapp
Description
Instead of having to enable feature flag per user via admin panel, this allows to enable it via ConfigCat instead, as well as will allow us to roll out this feature to more users via configCat.
Related Issue(s)
Fixes #12745
How to test
Open preview env
Add your user id to ConfigCat non production env
Open new workspace
In terminal:
ls -la /.workspace/.gitpod/and you should seepvcfile in there, indicating this workspace is running using PVC feature.Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide