Skip to content

Forward BillingTier to ConfigCat #13138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2022
Merged

Forward BillingTier to ConfigCat #13138

merged 2 commits into from
Sep 26, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 20, 2022 •
edited
Loading

Description

A first attempt at fixing #12840.

Instead of drilling this into BillingMode I opted for extending EntitlementService because it's a separate concern.
Still not super happy with the overhead we're creating, but want to unblock PVC.

We should really think about throwing it away afterwards. 🧹

Related Issue(s)

Fixes #12840

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@geropl geropl mentioned this pull request Sep 23, 2022
Closed
@geropl geropl marked this pull request as ready for review September 23, 2022 13:48
@geropl geropl requested a review from a team September 23, 2022 13:48
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 23, 2022
@geropl geropl requested a review from sagor999 September 23, 2022 13:53
@geropl
Copy link
Member Author

geropl commented Sep 23, 2022

/hold To give @sagor999 a chance to review: here are the values we can check in ConfigCat for.

sagor999
sagor999 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylos101 I guess we would need to change user flag for PVC to be controlled via ConfigCat now, instead of directly modifying it from admin panel.

@kylos101
Copy link
Contributor

@sagor999 indeed sir, that's the intent of #12745, which depended on this PR

@geropl
Copy link
Member Author

geropl commented Sep 26, 2022

/unhold

easyCZ
easyCZ approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geropl. This does the job tho I'd like we find a better way to approach this going forward. The multi-tier dependency of feature flags is a bit dangerous in terms of unexpected behaviour

@roboquat roboquat merged commit 3ed1465 into main Sep 26, 2022
@roboquat roboquat deleted the gpl/12840-cc-paid branch September 26, 2022 13:04
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConfigCat: forward property for PAID tier (Chargebee or Stripe)
5 participants
@geropl @kylos101 @easyCZ @sagor999 @roboquat