Replace workspace alerts from Jsonnet to YAML #12659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: devx
team: workspace
|
/hold because merge needs to be coordinated |
sagor999
approved these changes
Sep 6, 2022
utam0k
approved these changes
Sep 6, 2022
|
@gitpod-io/platform could I get a review pls? :) |
vulkoingim
approved these changes
Sep 8, 2022
Signed-off-by: ArthurSens <[email protected]>
ArthurSens
force-pushed
the
as/workspace-jsonnetless-alerts
branch
from
5d383d6 to
45103d4
Compare
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArthurSens [email protected]
Description
As socialized a couple of times before, our colleagues at Gitpod do not work well with Jsonnet, so we're slowly getting rid of all code we have in this language.
With the new observability installer, we're able to import YAML files stored in git. This means that we can replace alerts written in jsonnet with raw YAML that represents the PrometheusRule manifests we need.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: