Skip to content

Fix PrometheusRule name #12780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fix PrometheusRule name #12780

merged 1 commit into from
Sep 8, 2022

Conversation

ArthurSens
Copy link
Contributor

Signed-off-by: ArthurSens [email protected]

Description

In #12659, I replaced workspace alerts from jsonnet to YAML, but made a mistake with the naming 😕.

I use capital letters, and that is not compatible with kubernetes. For that reason, preview environments are failing to install monitoring-satellite and also ArgoCD is failing to update apps.

image
image

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

Signed-off-by: ArthurSens <[email protected]>
@ArthurSens ArthurSens requested a review from a team September 8, 2022 18:18
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Sep 8, 2022
@roboquat roboquat merged commit 9b382b6 into main Sep 8, 2022
@roboquat roboquat deleted the as/rule-name-fix branch September 8, 2022 18:31
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants