Skip to content

[code browser] measure all sessions vs errored sessions #12702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2022
Merged

[code browser] measure all sessions vs errored sessions #12702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0d8d97
[code browser]: Measure all sessions vs errored sessions
filiptronicek Sep 6, 2022
bf23f39
[installer] add vscode-workbench to allowlist
mustard-mh Sep 15, 2022
a11cdfb
[code] replace version during build time
mustard-mh Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WORKSPACE.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ defaultArgs:
jbMarketplacePublishTrigger: "false"
publishToJBMarketplace: true
localAppVersion: unknown
codeCommit: 43d126af25499c63c7462d0b7a961dfd797f896e
codeCommit: e2c3ab18a37bed1b4e43609a2c5a771ed4f07dbc
codeQuality: stable
noVerifyJBPlugin: false
intellijDownloadUrl: "https://download.jetbrains.com/idea/ideaIU-2022.2.2.tar.gz"
Expand Down
3 changes: 2 additions & 1 deletion components/ide/code/leeway.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ RUN yarn --cwd extensions compile \
# Check pkg/blobserve/blobserve.go, `inlineVars` method
RUN cp /vscode-web/out/vs/gitpod/browser/workbench/workbench.html /vscode-web/index.html \
&& cp /vscode-web/out/vs/gitpod/browser/workbench/callback.html /vscode-web/callback.html \
&& sed -i -e 's#static/##g' /vscode-web/index.html
&& sed -i -e 's#static/##g' /vscode-web/index.html \
&& sed -i -e "s/{{VERSION}}/$CODE_QUALITY-$CODE_COMMIT/g" /vscode-web/index.html

# cli config: alises to gitpod-code
RUN cp /vscode-reh-linux-x64/bin/remote-cli/gitpod-code /vscode-reh-linux-x64/bin/remote-cli/code \
Expand Down
3 changes: 2 additions & 1 deletion components/supervisor/frontend/src/ide/ide-metrics-service-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ const commit = require('../../config.json').commit;

export enum MetricsName {
SupervisorFrontendClientTotal = "gitpod_supervisor_frontend_client_total",
SupervisorFrontendErrorTotal = "gitpod_supervisor_frontend_error_total"
SupervisorFrontendErrorTotal = "gitpod_supervisor_frontend_error_total",
SupervisorFrontendLoadTotal = "gitpod_vscode_web_load_total",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We introduced a new metric: gitpod_vscode_web_load_total for measuring the percentage of failed loads.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitpod/install/installer/pkg/components/ide-metrics/configmap.go

Lines 50 to 58 in bc47002

Name: "gitpod_vscode_web_load_total",
Help: "Total count of supervisor frontend client loading / errored windows",
Labels: []config.LabelAllowList{
{
Name: "status",
AllowValues: []string{"loading", "failed"},
},
},
},

this metric can have two different types: loading and error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supervisor-frontend should be reverted, we should try to decouple metrics in VS Code Web workbench and here, and work on them separately. I think this PR should not have any changes in supervisor. cc @mustard-mh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustard-mh I don't think supervisor frontend should care about it.

}

const MetricsUrl = serverUrl.asIDEMetrics().toString();
Expand Down
19 changes: 17 additions & 2 deletions install/installer/cmd/testdata/render/aws-setup/output.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions install/installer/cmd/testdata/render/azure-setup/output.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions install/installer/cmd/testdata/render/customization/output.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions install/installer/cmd/testdata/render/external-registry/output.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions install/installer/cmd/testdata/render/gcp-setup/output.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions install/installer/cmd/testdata/render/http-proxy/output.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions install/installer/cmd/testdata/render/minimal/output.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions install/installer/cmd/testdata/render/statefulset-customization/output.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions install/installer/cmd/testdata/render/use-pod-security-policies/output.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading