[usage] Remove default controller schedule of 1h #12785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: webapp
easyCZ
force-pushed
the
mp/usage-installer-no-controller-default
branch
from
234d978 to
4e4869f
Compare
svenefftinge
approved these changes
Sep 9, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default config prevented from actually disabling the controller in the US.
We already set it to disabled in https://github.com/gitpod-io/ops/blob/main/deploy/production/meta-us02/app/installer-config.yaml#L168, however when the config is parsed, it's treated as unset and the default from the installer is used.
We remove the default to prevent this behaviour.
Description
Related Issue(s)
Fixes #
How to test
Unit tests
Release Notes
Documentation
Werft options: