Skip to content

[usage] Remove default controller schedule of 1h #12785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2022
Merged

[usage] Remove default controller schedule of 1h #12785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions install/installer/pkg/components/usage/configmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ package usage

import (
"fmt"
"time"

"github.com/gitpod-io/gitpod/common-go/baseserver"
"github.com/gitpod-io/gitpod/usage/pkg/server"

Expand All @@ -19,7 +17,7 @@ import (

func configmap(ctx *common.RenderContext) ([]runtime.Object, error) {
cfg := server.Config{
ControllerSchedule: time.Hour.String(),
ControllerSchedule: "", // By default controller is disabled
Server: &baseserver.Configuration{
Services: baseserver.ServicesConfiguration{
GRPC: &baseserver.ServerConfiguration{
Expand Down
1 change: 0 additions & 1 deletion install/installer/pkg/components/usage/configmap_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ func TestConfigMap_ContainsBillInstancesAfter(t *testing.T) {

require.JSONEq(t,
`{
"controllerSchedule": "1h0m0s",
"billInstancesAfter": "2022-08-04T00:00:00Z",
"stripeCredentialsFile": "stripe-secret/apikeys",
"server": {
Expand Down