-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[UBP] Remove team specific Stripe APIs from server
JSON-RPC API
#12957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f751771
to
0935c0c
Compare
started the job as gitpod-build-af-remove-team-specific-stripe-apis.4 because the annotations in the pull request description changed |
0935c0c
to
0a1bb73
Compare
/werft run 👍 started the job as gitpod-build-af-remove-team-specific-stripe-apis.17 |
Hi @andrew-farries! Many thanks for cleaning all these up. 🧹 While testing, I encountered one weird bug. Might be unrelated to your PR (because I see no dashboard changes), but here is what happened:
Setting the limit again to 200, and dismissing the alert, seems to fix it again. But still very confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks! ✨
Apart from the two really weird but unrelated-looking Usage Limit errors, this works as advertised. 🛹
Those usage limit errors do indeed look very odd. I assume they can also be repro'd in a preview based on |
Good point about tracking those in issues @andrew-farries -- also, many thanks for offering 💯 but given that you're on-call, I'm happy to try & repro these from |
Description
As part of #12685, several server APIs were generalised to work on user attribution ids as well as team attribution ids:
findStripeSubscriptionId
method to server #12876getStripePortalUrl
method to server #12864getUsageLimit
andsetUsageLimit
methods to server #12767subscribeToStripe
server method #12887With #12942 and #12954, the more specific team-only APIs are no longer used by the dashboard and are safe to remove.
Related Issue(s)
Part of #12685
How to test
Signing up teams and individual users for UBP still works.
Release Notes
Documentation
Werft options: