Skip to content

[UBP] Remove team specific Stripe APIs from server JSON-RPC API #12957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Sep 14, 2022

Description

As part of #12685, several server APIs were generalised to work on user attribution ids as well as team attribution ids:

With #12942 and #12954, the more specific team-only APIs are no longer used by the dashboard and are safe to remove.

⚠️ #12942 and #12954 need to be deployed first ⚠️

Related Issue(s)

Part of #12685

How to test

Signing up teams and individual users for UBP still works.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

Base automatically changed from af/create-user-stripe-customer-from-ui to main September 15, 2022 10:26
@roboquat roboquat added size/XL and removed size/M labels Sep 15, 2022
@andrew-farries andrew-farries force-pushed the af/remove-team-specific-stripe-apis branch from f751771 to 0935c0c Compare September 15, 2022 10:28
@roboquat roboquat added size/M and removed size/XL labels Sep 15, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-remove-team-specific-stripe-apis.4 because the annotations in the pull request description changed
(with .werft/ from main)

@andrew-farries andrew-farries force-pushed the af/remove-team-specific-stripe-apis branch from 0935c0c to 0a1bb73 Compare September 22, 2022 09:02
@andrew-farries andrew-farries marked this pull request as ready for review September 22, 2022 09:24
@andrew-farries andrew-farries requested a review from a team September 22, 2022 09:24
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 22, 2022
@andrew-farries
Copy link
Contributor Author

andrew-farries commented Sep 22, 2022

/werft run

👍 started the job as gitpod-build-af-remove-team-specific-stripe-apis.17
(with .werft/ from main)

@jankeromnes jankeromnes self-assigned this Sep 23, 2022
@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 23, 2022

Hi @andrew-farries! Many thanks for cleaning all these up. 🧹

While testing, I encountered one weird bug. Might be unrelated to your PR (because I see no dashboard changes), but here is what happened:

  1. Created a team called "Gitpod [Something]"
  2. Upgraded that team to Usage-Based
  3. Checked that the Customer Portal worked ✅
  4. Tried to change the limit from 100 to 200 credits
  5. This seemed to work, but after a refresh I somehow landed in this state:

Screenshot 2022-09-23 at 09 08 50

Setting the limit again to 200, and dismissing the alert, seems to fix it again. But still very confusing.

@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 23, 2022

Then, I tried the same for individual billing:

  1. Upgrade to Usage-Based
  2. Change the usage limit from 100 to 200
  3. Refresh...

Screenshot 2022-09-23 at 09 13 33

🙈 what is going on with these limits?

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! ✨

Apart from the two really weird but unrelated-looking Usage Limit errors, this works as advertised. 🛹

@roboquat roboquat merged commit 317d157 into main Sep 23, 2022
@roboquat roboquat deleted the af/remove-team-specific-stripe-apis branch September 23, 2022 07:18
@andrew-farries
Copy link
Contributor Author

Those usage limit errors do indeed look very odd. I assume they can also be repro'd in a preview based on main? We should have issues for them if we don't already. Want me to have a look or do you want to do it?

@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 23, 2022

Good point about tracking those in issues @andrew-farries -- also, many thanks for offering 💯 but given that you're on-call, I'm happy to try & repro these from main and file issues about them this afternoon. 👍

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants