[Stripe] Enable automatic tax on transactions #13002

jankeromnes · 2022-09-15T13:27:38Z

Description

Enable automatic tax on Stripe transactions:

Since we're already asking users for a country when they provide a payment method, we might as set their customer's country by default
Refactor StripeService methods to utilize attributionId more and pass around IDs instead of (possibly outdated) Stripe objects
When creating new subscriptions in supported Stripe Tax regions, pass along automatic_tax: { enabled: true } to enable automatic tax collection for these subscriptions

Related Issue(s)

Fixes #13000

How to test

Create a team called "Gitpod [Something]"
Add a payment method from a tax-supported country (i.e. any country from the EU or the UK)
Once subscribed, open your Stripe customer portal: the country in your billing address should be the same as in 2. (and not "United States" by default)
In the Stripe admin dashboard, automatic tax collection should be enabled for your subscription
Now cancel the subscription (or create a new team -- should work the same)
Add a payment method from a tax-unsupported country (e.g. Canada)
Subscribing should still work successfully
In the Stripe admin dashboard, automatic tax collection should not be enabled for your new subscription

Release Notes

NONE

Documentation

Werft options:

/werft with-clean-slate-deployment
/werft with-preview
/werft with-payment

jankeromnes · 2022-09-15T13:33:54Z

/werft run

👍 started the job as gitpod-build-jx-stripe-tax.1
(with .werft/ from main)

jankeromnes · 2022-09-15T13:37:13Z

/werft run

👍 started the job as gitpod-build-jx-stripe-tax.2
(with .werft/ from main)

jankeromnes · 2022-09-15T14:15:27Z

Depends on #13008

components/server/ee/src/billing/billing-mode.spec.db.ts

svenefftinge · 2022-09-23T08:09:52Z

components/server/ee/src/user/stripe-service.ts

            invoice_settings: { default_payment_method: setupIntent.payment_method },
+            ...(paymentMethod.billing_details.address?.country
+                ? { address: { line1: "", country: paymentMethod.billing_details.address?.country } }


Do you know why line1 is mandatory? Why don't you copy over the full address here?

line1 isn't actually mandatory: https://stripe.com/docs/api/customers/create#create_customer-address-line1

However, it seems that Stripe's TypeScript bindings marked it as mandatory, so I provide an empty value (undefined or null were not allowed, but I believe the result is the same).

Also, the country by itself is already the full address we get from the upgrade flow (we only ask for country, not for a full billing address, so new subscribers didn't have a change to fill this in yet):

However, I'm not exactly sure what happens if:

You subscribe from a given country

Then, you set a complete billing address (e.g. all lines) in your Stripe customer portal

Then, you cancel

Then, you subscribe from a different country

It's sort of an edge case, but should also be tested. Thanks for pointing it out!

Okay, I've tested it -- if you cancel and re-subscribe from a different country, your billing address is entirely reset:

I think that's a good thing.

…yAttributionId

…ly outdated) objects

…rs in supported regions

…m} to createStripeCustomer

…cription to only use attributionIds

jankeromnes · 2022-09-23T09:57:59Z

Weird 🤔 server is now in CrashLoopBackOff due to:

Error: A metric with the name process_cpu_user_seconds_total has already been registered.
    at Registry.registerMetric (/app/node_modules/prom-client/lib/registry.js:80:10)

Maybe let's rebase & build with-clean-slate just in case.

werft-gitpod-dev-com · 2022-09-23T09:58:25Z

started the job as gitpod-build-jx-stripe-tax.27 because the annotations in the pull request description changed
(with .werft/ from main)

jankeromnes · 2022-09-23T10:20:09Z

Let's try this again:

/werft run

👍 started the job as gitpod-build-jx-stripe-tax.30
(with .werft/ from main)

werft-gitpod-dev-com · 2022-09-23T10:20:13Z

started the job as gitpod-build-jx-stripe-tax.29 because the annotations in the pull request description changed
(with .werft/ from main)

…nIds

roboquat added release-note-none do-not-merge/work-in-progress size/XS labels Sep 15, 2022

jankeromnes force-pushed the jx/stripe-tax branch 2 times, most recently from 96153ca to 6d1ad9f Compare September 15, 2022 14:13

jankeromnes mentioned this pull request Sep 15, 2022

[werft] Update Stripe prices used in preview environments to allow testing taxes #13008

Merged

1 task

jankeromnes changed the title ~~Enable automatic tax on Stripe transactions~~ [Stripe] Enable automatic tax on transactions Sep 15, 2022

jankeromnes force-pushed the jx/stripe-tax branch 2 times, most recently from 1c0d27b to 80b3c87 Compare September 16, 2022 09:26

This comment was marked as outdated.

Sign in to view

jankeromnes force-pushed the jx/stripe-tax branch from 80b3c87 to 3eacb5e Compare September 19, 2022 09:37

roboquat added size/M and removed size/XS labels Sep 19, 2022

jankeromnes force-pushed the jx/stripe-tax branch 4 times, most recently from 9c26407 to 98b5f19 Compare September 19, 2022 14:11

roboquat added size/L and removed size/M labels Sep 19, 2022

jankeromnes force-pushed the jx/stripe-tax branch 4 times, most recently from 62b578c to fdb0663 Compare September 20, 2022 15:12

roboquat added size/XL and removed size/L labels Sep 21, 2022

jankeromnes force-pushed the jx/stripe-tax branch 2 times, most recently from e7eeca9 to ee04da1 Compare September 21, 2022 13:03

roboquat removed the do-not-merge/work-in-progress label Sep 23, 2022

svenefftinge reviewed Sep 23, 2022

View reviewed changes

components/server/ee/src/billing/billing-mode.spec.db.ts Outdated Show resolved Hide resolved

svenefftinge reviewed Sep 23, 2022

View reviewed changes

jankeromnes force-pushed the jx/stripe-tax branch from 527bfda to 8c5d1df Compare September 23, 2022 08:23

roboquat added size/XL and removed size/L labels Sep 23, 2022

jankeromnes force-pushed the jx/stripe-tax branch from 8c5d1df to 30bc293 Compare September 23, 2022 08:38

jankeromnes marked this pull request as draft September 23, 2022 08:42

roboquat added the do-not-merge/work-in-progress label Sep 23, 2022

jankeromnes force-pushed the jx/stripe-tax branch from 30bc293 to 361616f Compare September 23, 2022 09:21

jankeromnes added 6 commits September 23, 2022 09:56

[server] Set Stripe customer country when attaching a payment method

3a0dcb4

[server] Refactor StripeService.findCustomerByQuery to .findCustomerB…

ea8523f

…yAttributionId

[server] Refactor StripeService to pass around IDs instead of (possib…

9099988

…ly outdated) objects

[server] Enable automatic tax on new Stripe subscriptions for custome…

7217ad3

…rs in supported regions

[server][dashboard] Refactor createOrUpdateStripeCustomerFor{User,Tea…

cfa3bed

…m} to createStripeCustomer

[server] Refactor StripeService.findCustomer and .findUncancelledSubs…

d3e5716

…cription to only use attributionIds

jankeromnes force-pushed the jx/stripe-tax branch from 361616f to 244e43b Compare September 23, 2022 09:58

[server] Refactor StripeService.createCustomer to only use attributio…

ad8d0ac

…nIds

jankeromnes force-pushed the jx/stripe-tax branch from 244e43b to ad8d0ac Compare September 23, 2022 13:20

jankeromnes marked this pull request as ready for review September 23, 2022 13:47

roboquat removed the do-not-merge/work-in-progress label Sep 23, 2022

svenefftinge approved these changes Sep 23, 2022

View reviewed changes

roboquat merged commit a99b0c3 into main Sep 23, 2022

roboquat deleted the jx/stripe-tax branch September 23, 2022 13:53

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Stripe] Enable automatic tax on transactions #13002

[Stripe] Enable automatic tax on transactions #13002

jankeromnes commented Sep 15, 2022 •

edited

Loading

jankeromnes commented Sep 15, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 15, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 15, 2022

This comment was marked as outdated.

svenefftinge Sep 23, 2022 •

edited

Loading

jankeromnes Sep 23, 2022 •

edited

Loading

jankeromnes Sep 23, 2022 •

edited

Loading

jankeromnes commented Sep 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

werft-gitpod-dev-com bot commented Sep 23, 2022

jankeromnes commented Sep 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

werft-gitpod-dev-com bot commented Sep 23, 2022

[Stripe] Enable automatic tax on transactions #13002

[Stripe] Enable automatic tax on transactions #13002

Conversation

jankeromnes commented Sep 15, 2022 • edited Loading

Description

Related Issue(s)

How to test

Release Notes

Documentation

Werft options:

jankeromnes commented Sep 15, 2022 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Sep 15, 2022 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Sep 15, 2022

This comment was marked as outdated.

svenefftinge Sep 23, 2022 • edited Loading

Choose a reason for hiding this comment

jankeromnes Sep 23, 2022 • edited Loading

Choose a reason for hiding this comment

jankeromnes Sep 23, 2022 • edited Loading

Choose a reason for hiding this comment

jankeromnes commented Sep 23, 2022 • edited by werft-gitpod-dev-com bot Loading

werft-gitpod-dev-com bot commented Sep 23, 2022

jankeromnes commented Sep 23, 2022 • edited by werft-gitpod-dev-com bot Loading

werft-gitpod-dev-com bot commented Sep 23, 2022

jankeromnes commented Sep 15, 2022 •

edited

Loading

jankeromnes commented Sep 15, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 15, 2022 •

edited by werft-gitpod-dev-com bot

Loading

svenefftinge Sep 23, 2022 •

edited

Loading

jankeromnes Sep 23, 2022 •

edited

Loading

jankeromnes Sep 23, 2022 •

edited

Loading

jankeromnes commented Sep 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading