Skip to content

[werft] Update Stripe prices used in preview environments to allow testing taxes #13008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

[werft] Update Stripe prices used in preview environments to allow testing taxes #13008

merged 1 commit into from
Sep 15, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Sep 15, 2022 •
edited
Loading

Description

Update Stripe prices used in preview environments to allow testing taxes.

Related Issue(s)

Helps with #13002

How to test

  1. Should build

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@jankeromnes jankeromnes mentioned this pull request Sep 15, 2022
Merged
6 tasks
@jankeromnes jankeromnes requested a review from a team September 15, 2022 14:30
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 15, 2022
laushinka
laushinka reviewed Sep 15, 2022
View reviewed changes
.werft/jobs/build/payment/stripe-configmap.yaml
"EUR": "price_1LFZhJGadRXm50o3v27S1DB1",
"USD": "price_1LFZhJGadRXm50o3YEAaspXu"
"EUR": "price_1LiId7GadRXm50o3OayAS2y4",
"USD": "price_1LiIdbGadRXm50o3ylg5S44r"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these mean? 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @laushinka!

These are the ID of the Prices used when creating new subscriptions. They should correspond to a Price in our Stripe Product "Gitpod Usage": https://dashboard.stripe.com/test/products?active=true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created new Prices in our "test" Stripe account, with tax enabled, so that we can test tax things in preview environments. (Our previous Prices were not tax compatible, because we hadn't enabled Stripe Tax in the "test" account yet.)

Merging this update should unblock work on #13002 (which currently fails because it's impossible to subscribe with automatic tax enabled to a price that is not tax compatible) 😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@jankeromnes jankeromnes requested a review from a team September 15, 2022 14:43
@roboquat roboquat merged commit c4dfba3 into main Sep 15, 2022
@roboquat roboquat deleted the jx/stripe-tax-prices branch September 15, 2022 15:00
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laushinka laushinka laushinka approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jankeromnes @laushinka @roboquat