Skip to content

Use go to install latest obs-installer #13038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2022
Merged

Use go to install latest obs-installer #13038

merged 2 commits into from
Sep 16, 2022

Conversation

vulkoingim
Copy link
Contributor

@vulkoingim vulkoingim commented Sep 16, 2022 •
edited
Loading

Description

#12989 fixed the issue with installing the obs-installer, so we no longer need to clone the repository anymore.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@vulkoingim vulkoingim requested a review from a team September 16, 2022 12:12
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-go-obs-installer.1 because the annotations in the pull request description changed
(with .werft/ from main)

mads-hartmann
mads-hartmann reviewed Sep 16, 2022
View reviewed changes
.werft/observability/install-satellite.sh
mkdir -p "${obsDir}"
git clone https://roboquat:"$(cat /mnt/secrets/monitoring-satellite-preview-token/token)"@github.com/gitpod-io/observability.git "${obsDir}"
cd "${obsDir}/installer"
GOBIN=$(pwd) go install github.com/gitpod-io/observability/installer@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to have the binary be named "observability-installer" just to avoid confusing it with the Gitpod Installer.

Alternatively rm ./installer after line 31 would also work

@mads-hartmann
Copy link
Contributor

started the job as gitpod-build-aa-go-obs-installer.1 because the annotations in the pull request description changed
(with .werft/ from main)

@vulkoingim To test this you'll need to run werft job run github to work around job protection

@roboquat roboquat added size/S and removed size/XS labels Sep 16, 2022
mads-hartmann
mads-hartmann approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Added the hold label to give you time to test this. It also seems like the Werft build is broken for what looks like unrelated reasons

@vulkoingim
Copy link
Contributor Author

Changes look good to me. Added the hold label to give you time to test this. It also seems like the Werft build is broken for what looks like unrelated reasons

I deleted the job, as I was running it manually.

This is a manual run: https://werft.gitpod-dev.com/job/gitpod-custom-aa-go-obs-installer.2

I'l retrigger so it allows the merge.

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-go-obs-installer.3 because the annotations in the pull request description changed
(with .werft/ from main)

@vulkoingim
Copy link
Contributor Author

vulkoingim commented Sep 16, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aa-go-obs-installer.4
(with .werft/ from main)

@roboquat roboquat merged commit 15462e1 into main Sep 16, 2022
@roboquat roboquat deleted the aa/go-obs-installer branch September 16, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann approved these changes

Assignees
No one assigned
Labels
release-note-none size/S team: devx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vulkoingim @mads-hartmann @roboquat