Unset GOFLAGS from Dockerfile and update images #12989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vulkoingim
force-pushed
the
aa/unset-goflags
branch
from
c61100a to
6b681d3
Compare
|
|
github-actions
bot
added
team: IDE
team: delivery
vulkoingim
changed the title
Furisto
approved these changes
Sep 15, 2022
mrsimonemms
approved these changes
Sep 15, 2022
ArthurSens
approved these changes
Sep 15, 2022
mustard-mh
approved these changes
Sep 16, 2022
1 task
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-mod=readonlyis the default option (since 1.14) if there is no vendor directory present (and we don't vendor anything from what I can see). This flag was set ~2y ago.Not entirely sure the exact interaction which leads to the issue - I imagine it might be some weird combination of
gitpod-io/gitpodbeing a monorepo with multiplego.modfiles and not using workspaces ¯_(ツ)_/¯ But ultimately it does fix installing/updating packages that rely on 1.18+Related Issue(s)
Fixes https://gitpod.slack.com/archives/C032A46PWR0/p1663224067876619
How to test
Release Notes
Documentation
Werft options: