Skip to content

Track git branches during initial checkout #13210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2022
Merged

Track git branches during initial checkout #13210

merged 2 commits into from
Sep 23, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 22, 2022 •
edited
Loading

Description

Partially reverts #13053 due to not tracking remote branches, something that impacts the commit used in the workspace (not the last one)

Internal report https://gitpod.slack.com/archives/C01KGM9BH54/p1663846572842519

How to test

Release Notes

NONE

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-track.1 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/S and removed size/XS labels Sep 22, 2022
@aledbf
Copy link
Member Author

aledbf commented Sep 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-track.3
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Sep 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-track.6
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Sep 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-track.10
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review September 22, 2022 15:33
@aledbf aledbf requested a review from a team September 22, 2022 15:33
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-track.16 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Sep 22, 2022
@aledbf
Copy link
Member Author

aledbf commented Sep 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft with-integration-tests=workspace

👎 unknown command: with-integration-tests=workspace
Use /werft help to list the available commands

@aledbf
Copy link
Member Author

aledbf commented Sep 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft help

👍 You can interact with werft using: /werft command <args>.
Available commands are:

  • /werft run [annotation=value] which starts a new werft job from this context.
    You can optionally pass multiple whitespace-separated annotations.
  • /werft help displays this help

@aledbf
Copy link
Member Author

aledbf commented Sep 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-integration-tests=workspace

👍 started the job as gitpod-build-aledbf-track.17
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-track.18 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Sep 23, 2022

cc @akosyakov

jenting
jenting approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test against prebuild, regular, and multiple repos. All work well.

@roboquat roboquat merged commit 9aa153e into main Sep 23, 2022
@roboquat roboquat deleted the aledbf/track branch September 23, 2022 07:03
@andrew-farries andrew-farries mentioned this pull request Sep 23, 2022
Closed
3 tasks
@aledbf aledbf mentioned this pull request Sep 23, 2022
Merged
3 tasks
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

Assignees

@aledbf aledbf

Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @jenting @roboquat