Skip to content

[content-service] Fix git checkout #13241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

[content-service] Fix git checkout #13241

merged 1 commit into from
Sep 23, 2022

Conversation

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-git.46 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/S and removed size/XS labels Sep 23, 2022
@aledbf aledbf marked this pull request as ready for review September 23, 2022 16:25
@aledbf aledbf requested a review from a team September 23, 2022 16:25
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Sep 23, 2022
@aledbf
Copy link
Member Author

aledbf commented Sep 23, 2022

/werft run with-integration-tests=workspace

👍 started the job as gitpod-build-aledbf-git.51
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Sep 23, 2022

/werft run

👍 started the job as gitpod-build-aledbf-git.52
(with .werft/ from main)

Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.
Adding hold in case if you want to do additional testing prior to merge or have someone else take a peek at code as well. Otherwise feel free to unhold.

/hold

@roboquat roboquat merged commit 943e228 into main Sep 23, 2022
@roboquat roboquat deleted the aledbf/git branch September 23, 2022 18:28
@sagor999
Copy link
Contributor

Oh great, roboquat ignored hold label. 🤦

@aledbf aledbf restored the aledbf/git branch September 23, 2022 18:31
@jenting jenting deleted the aledbf/git branch September 26, 2022 03:20
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-git.54 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Sep 26, 2022

I encounter the below error when running the integration test, which only happens without PVC.

cannot wait for workspace start: "workspace instance 1c7a2072-0461-49ae-964e-51d1d0302362 failed: cannot initialize workspace: cannot initialize workspace: git initializer clone: git ls-remote --exit-code origin main failed (exit status 2): "

I believe it's because we use the gitpod-io/empty repo for testing, and running this command locally failed with exit status 2 as well.

$ git ls-remote --exit-code origin main

@roboquat roboquat added the deployed Change is completely running in production label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production do-not-merge/hold release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants