-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[content-service] Fix git checkout #13241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-aledbf-git.46 because the annotations in the pull request description changed |
/werft run with-integration-tests=workspace 👍 started the job as gitpod-build-aledbf-git.51 |
/werft run 👍 started the job as gitpod-build-aledbf-git.52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
Adding hold in case if you want to do additional testing prior to merge or have someone else take a peek at code as well. Otherwise feel free to unhold.
/hold
Oh great, roboquat ignored hold label. 🤦 |
started the job as gitpod-build-aledbf-git.54 because the annotations in the pull request description changed |
I encounter the below error when running the integration test, which only happens without PVC. cannot wait for workspace start: "workspace instance 1c7a2072-0461-49ae-964e-51d1d0302362 failed: cannot initialize workspace: cannot initialize workspace: git initializer clone: git ls-remote --exit-code origin main failed (exit status 2): " I believe it's because we use the gitpod-io/empty repo for testing, and running this command locally failed with exit status 2 as well.
|
Description
Avoid reverting the changes #13210 and #13053
Test
Open different workspaces that triggered the changes
Release Notes
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide