Run pre-commit checks before other validation checks #13224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vulkoingim
approved these changes
Sep 23, 2022
|
/hold 👍 started the job as gitpod-build-mads-run-pre-commit-before-other-validations.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run pre-commit checks before other validation checks. Since running the validation steps in parallel we've seen issues with multiple processes trying to modify .git. We think this might be a conflict between the pre-commit checks and the other validations; specifically that both pre-commit checks and
leeyway vetrun Leeway. This PR runs the pre-commit checks first, and then runs the rest in parallel.This is mainly based on a hunch - as this is breaking builds now I decided to try a quick-fix rather than do a deep investigation.
Related Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/5345
How to test
Run without job protection to see the changes - job here
Release Notes
Documentation
N/A
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide