Skip to content

Run pre-commit checks before other validation checks #13224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Run pre-commit checks before other validation checks #13224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .werft/jobs/build/validate-changes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ import { JobConfig } from "./job-config";

export async function validateChanges(werft: Werft, config: JobConfig) {
werft.phase("validate-changes", "validating changes");
// We run pre-commit checks first to avoid potential race conditions with the
// other validation checks.
await preCommitCheck(werft);
await Promise.all([
branchNameCheck(werft, config),
preCommitCheck(werft),
typecheckWerftJobs(werft),
leewayVet(werft),
]);
Expand Down