Skip to content

[public-api] Define experimental TeamsService.CreateTeam protos #14151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Oct 25, 2022

Description

Defines a TeamsService with initial CreateTeam RPC on it. If you'd like to see how the service would look like with all RPCs, see here.

The final result (once the individual pieces are landed), with dashboard using the API to Create teams is available here as a PoC.

The RPC will be implemented in subsequent PRs.

Related Issue(s)

Fixes #

How to test

NONE

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ easyCZ force-pushed the mp/papi-experimental-teams-service branch from e0dddc3 to 9227f67 Compare October 26, 2022 20:16
@easyCZ easyCZ changed the title [public-api] Define experimental TeamService.CreateTeam protos [public-api] Define experimental TeamsService.CreateTeam protos Oct 26, 2022
@easyCZ easyCZ marked this pull request as ready for review October 26, 2022 20:19
@easyCZ easyCZ requested review from a team October 26, 2022 20:19
@github-actions github-actions bot added team: SID team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Oct 26, 2022

enum TeamRole {
// TEAM_ROLE_UNKNOWN is the unkwnon state.
TEAM_ROLE_UNSPECIFIED = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto LGTM ☑️

@roboquat roboquat merged commit e84bd1f into main Oct 27, 2022
@roboquat roboquat deleted the mp/papi-experimental-teams-service branch October 27, 2022 11:27
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note-none size/L team: IDE team: SID team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants