Skip to content

[public-api] Add experimental TeamsService #14212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2022
Merged

[public-api] Add experimental TeamsService #14212

merged 1 commit into from
Oct 31, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Oct 26, 2022 •
edited
Loading

Description

Adds protobuf definitions for experimental TeamsService

Related Issue(s)

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ easyCZ force-pushed the mp/papi-experimental-teams-service-2 branch from d11c6cf to ecc64d7 Compare October 26, 2022 20:12
@easyCZ easyCZ mentioned this pull request Oct 26, 2022
Merged
4 tasks
@easyCZ easyCZ force-pushed the mp/papi-experimental-teams-service-2 branch from ecc64d7 to f0c8cf4 Compare October 31, 2022 06:38
@roboquat roboquat added size/M and removed size/XL labels Oct 31, 2022
@easyCZ easyCZ marked this pull request as ready for review October 31, 2022 07:03
@easyCZ easyCZ requested review from a team October 31, 2022 07:03
@github-actions github-actions bot added team: SID team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Oct 31, 2022
@easyCZ easyCZ force-pushed the mp/papi-experimental-teams-service-2 branch from f0c8cf4 to 07028af Compare October 31, 2022 07:05
@roboquat roboquat added size/L and removed size/M labels Oct 31, 2022
andrew-farries
andrew-farries approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for one nit and a question

@easyCZ easyCZ force-pushed the mp/papi-experimental-teams-service-2 branch from 07028af to a1615f1 Compare October 31, 2022 13:49
@easyCZ
Copy link
Member Author

easyCZ commented Oct 31, 2022

/unhold

@roboquat roboquat merged commit b8e9226 into main Oct 31, 2022
@roboquat roboquat deleted the mp/papi-experimental-teams-service-2 branch October 31, 2022 13:52
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

@ArthurSens ArthurSens ArthurSens approved these changes

@csweichel csweichel Awaiting requested review from csweichel

@akosyakov akosyakov Awaiting requested review from akosyakov

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note-none size/L team: IDE team: SID team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@easyCZ @andrew-farries @ArthurSens @roboquat