Skip to content

Make strings translatable (#1188) #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2017
Merged

Make strings translatable (#1188) #1198

merged 2 commits into from
Mar 11, 2017

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented Mar 10, 2017

Fixes #1188

@lunny lunny added this to the 1.2.0 milestone Mar 10, 2017
@lunny
Copy link
Member

lunny commented Mar 10, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 10, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2017
@lunny lunny merged commit ccc15b9 into go-gitea:master Mar 11, 2017
lunny added a commit to lunny/gitea that referenced this pull request Mar 11, 2017
@lunny
fix 500 caused by branches settings introduced by go-gitea#1198
68da001
lunny added a commit that referenced this pull request Mar 12, 2017
@lunny
fix 500 caused by branches settings introduced by #1198 (#1214)
608bbed
@pgaskin pgaskin deleted the patch-3 branch May 24, 2017 01:12
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Untranslatable string
5 participants
@pgaskin @lunny @ethantkoenig @tboerger @geek1011