Fix 500 caused by branches settings introduced by #1198 #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trusted LGTM |
tboerger
added
the
lgtm/need 1
|
It's good, sorry about the bug I caused. Thanks for fixing it @lunny. I will check more carefully that I pushed everything to my branch next time because I amended that same fix to my own PR, but forgot to force push. |
|
@geek1011 don't worry, more tests will resolve this-like problems. I have ever pushed many broken PRs. |
|
@geek1011 the best way to be more careful is to write more tests, a lot of work has gone to that direction already, are you up to make your hands dirty in that land ? |
|
LGTM |
tboerger
added
lgtm/done
|
@strk Yes, I am getting familiar with tests right now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@geek1011